fix(specs): consequence is required when saving rules (generated)

algolia/api-clients-automation#4146 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia · Nov 26, 2024 · 2f644d2 · 2f644d2
1 parent 43a024e
commit 2f644d2
Show file tree

Hide file tree

Showing 15 changed files with 92 additions and 266 deletions.
diff --git a/package.json b/package.json
@@ -6,7 +6,7 @@
     "packages/*"
   ],
   "scripts": {
-    "build": "lerna run build --scope '@algolia/requester-testing' --scope '@algolia/logger-console' --scope 'algoliasearch' --scope '@algolia/client-composition' --include-dependencies",
+    "build": "lerna run build --skip-nx-cache --scope '@algolia/requester-testing' --scope '@algolia/logger-console' --scope 'algoliasearch' --scope '@algolia/client-composition' --include-dependencies",
     "clean": "lerna run clean",
     "release:publish": "tsc --project scripts/tsconfig.json && node scripts/dist/publish.js",
     "test": "lerna run test $*",

diff --git a/packages/algoliasearch/rollup.config.js b/packages/algoliasearch/rollup.config.js
@@ -2,6 +2,7 @@ export default [
   {
     input: 'dist/lite/builds/browser.min.js',
     external: ['dom'],
+    cache: false,
     output: {
       esModule: false,
       file: 'dist/lite/builds/browser.umd.js',

diff --git a/packages/client-abtesting/rollup.config.js b/packages/client-abtesting/rollup.config.js
@@ -2,6 +2,7 @@ export default [
   {
     input: 'dist/builds/browser.min.js',
     external: ['dom'],
+    cache: false,
     output: {
       esModule: false,
       file: 'dist/builds/browser.umd.js',

diff --git a/packages/client-analytics/rollup.config.js b/packages/client-analytics/rollup.config.js
@@ -2,6 +2,7 @@ export default [
   {
     input: 'dist/builds/browser.min.js',
     external: ['dom'],
+    cache: false,
     output: {
       esModule: false,
       file: 'dist/builds/browser.umd.js',

diff --git a/packages/client-composition/rollup.config.js b/packages/client-composition/rollup.config.js
@@ -2,6 +2,7 @@ export default [
   {
     input: 'dist/builds/browser.min.js',
     external: ['dom'],
+    cache: false,
     output: {
       esModule: false,
       file: 'dist/builds/browser.umd.js',

diff --git a/packages/client-insights/rollup.config.js b/packages/client-insights/rollup.config.js
@@ -2,6 +2,7 @@ export default [
   {
     input: 'dist/builds/browser.min.js',
     external: ['dom'],
+    cache: false,
     output: {
       esModule: false,
       file: 'dist/builds/browser.umd.js',

diff --git a/packages/client-personalization/rollup.config.js b/packages/client-personalization/rollup.config.js
@@ -2,6 +2,7 @@ export default [
   {
     input: 'dist/builds/browser.min.js',
     external: ['dom'],
+    cache: false,
     output: {
       esModule: false,
       file: 'dist/builds/browser.umd.js',

diff --git a/packages/client-query-suggestions/rollup.config.js b/packages/client-query-suggestions/rollup.config.js
@@ -2,6 +2,7 @@ export default [
   {
     input: 'dist/builds/browser.min.js',
     external: ['dom'],
+    cache: false,
     output: {
       esModule: false,
       file: 'dist/builds/browser.umd.js',

diff --git a/packages/client-search/model/rule.ts b/packages/client-search/model/rule.ts
@@ -18,7 +18,7 @@ export type Rule = {
    */
   conditions?: Array<Condition>;
 
-  consequence?: Consequence;
+  consequence: Consequence;
 
   /**
    * Description of the rule\'s purpose to help you distinguish between different rules.

diff --git a/packages/client-search/rollup.config.js b/packages/client-search/rollup.config.js
@@ -2,6 +2,7 @@ export default [
   {
     input: 'dist/builds/browser.min.js',
     external: ['dom'],
+    cache: false,
     output: {
       esModule: false,
       file: 'dist/builds/browser.umd.js',

diff --git a/packages/client-search/src/searchClient.ts b/packages/client-search/src/searchClient.ts
@@ -2346,6 +2346,9 @@ export function createSearchClient({
       if (!rule.objectID) {
         throw new Error('Parameter `rule.objectID` is required when calling `saveRule`.');
       }
+      if (!rule.consequence) {
+        throw new Error('Parameter `rule.consequence` is required when calling `saveRule`.');
+      }
 
       const requestPath = '/1/indexes/{indexName}/rules/{objectID}'
         .replace('{indexName}', encodeURIComponent(indexName))

diff --git a/packages/ingestion/rollup.config.js b/packages/ingestion/rollup.config.js
@@ -2,6 +2,7 @@ export default [
   {
     input: 'dist/builds/browser.min.js',
     external: ['dom'],
+    cache: false,
     output: {
       esModule: false,
       file: 'dist/builds/browser.umd.js',

diff --git a/packages/monitoring/rollup.config.js b/packages/monitoring/rollup.config.js
@@ -2,6 +2,7 @@ export default [
   {
     input: 'dist/builds/browser.min.js',
     external: ['dom'],
+    cache: false,
     output: {
       esModule: false,
       file: 'dist/builds/browser.umd.js',

diff --git a/packages/recommend/rollup.config.js b/packages/recommend/rollup.config.js
@@ -2,6 +2,7 @@ export default [
   {
     input: 'dist/builds/browser.min.js',
     external: ['dom'],
+    cache: false,
     output: {
       esModule: false,
       file: 'dist/builds/browser.umd.js',