feat: Upgrade algoliasearch v5 #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `algoliasearch` package from version 4.24.0 to 5.19.0. - Updated `instantsearch.js` and `instantsearch.css` to versions 4.75.7 and 8.5.1 respectively. - Refactored file paths in `copy-files-from-to.json` to reflect new library structure.
- Changed import statement for `algoliasearch` to destructured format. - Updated test setup to use `client.searchSingleIndex` instead of `index.search` for improved clarity and alignment with the latest Algolia API. - Adjusted search parameters to utilize the environment variable for index name. These changes enhance the maintainability and readability of the test code while ensuring compatibility with the updated Algolia library.
sbellone
reviewed
Jan 24, 2025
package.json
Outdated
| @@ -36,7 +36,7 @@ | |||
| "@algolia/autocomplete-theme-classic": "1.12.1", | |||
There was a problem hiding this comment.
It's a good occasion to upgrade Autocomplete too.
Actually I did it in #180, so if you merge develop it should be updated to the latest version.
Sorry for the conflicts, normally you can just take the version from develop
cartridges/int_algolia/cartridge/templates/default/algolia/headerScripts.isml
Outdated
Show resolved
Hide resolved
…derScripts.isml Co-authored-by: Sylvain Bellone <sylvain.bellone@algolia.com>
sbellone
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed
algoliasearchpackage from version 4.24.0 to 5.19.0.instantsearch.jsandinstantsearch.cssto versions 4.75.7 and 8.5.1 respectively.copy-files-from-to.jsonto reflect new library structure.