Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): missing search dependency #3988

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Oct 18, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3085

Changes included:

closes algolia/algoliasearch-client-javascript#1562

the search client wasn't in the dependencies anymore

@shortcuts shortcuts self-assigned this Oct 18, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 18, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 000eb4923d0938ab321beb1313eb2679f3ee4854
🍃 Generated commit 1b50c2c1f6748f4b93592c7623e12621dfb02415
🌲 Generated branch generated/fix/missing-javascript-dependency
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1694
go 1677
php 1497
csharp 1365
java 1112
python 1033
ruby 845
swift 755

@shortcuts shortcuts merged commit b076b69 into main Oct 18, 2024
29 checks passed
@shortcuts shortcuts deleted the fix/missing-javascript-dependency branch October 18, 2024 08:12
algolia-bot added a commit that referenced this pull request Oct 18, 2024
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 18, 2024
algolia/api-clients-automation#3988

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Latest release breaks algoliasearch types
3 participants