Fix Email Input Type and Improve Error Messaging on Signup and Login Pages #180
Conversation
Fix Email Input Type and Improve Error Messaging on Signup and Login Pages
|
@Aniket-2504 is attempting to deploy a commit to the Alogovengers' projects Team on Vercel. A member of the Team first needs to authorize it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Awesome work, @Aniket-2504! 🎉 Thank you for your contribution and efforts to enhance Hairify.
We will review your changes soon and provide feedback.
Please ensure that you have followed the contributing guidelines for a smooth review process.
| @@ -29,21 +31,21 @@ function SignupInner() { | |||
| const [Signingup, setSigningUp] = useState<boolean>(false); | |||
|
|
|||
| const handleSignup = async (e: React.MouseEvent<HTMLButtonElement, MouseEvent>) => { | |||
| e.preventDefault(); | |||
| // e.preventDefault(); | |||
There was a problem hiding this comment.
Any specific reason for this?
|
I removed e.preventDefault(); because it was handling the required error, which prevented the browser from showing it to the user. Now, the browser handles the required error now its shows properly you can see it in screenshots, |
|
Thank you bro for giving me this opportunity. |
|
hello bro is everything all right ? |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The toast is looking pretty weird as per the design, can we just show the message there instead of showing the toast. |
|
can i change the position of toast or show the message only ? |
|
Please show messages only! |
|
ok bro thanks , ill work on it |
Description:
fixes #129
This pull request addresses the issues described in issue #129 regarding the email input type and error messaging on the signup and login pages.
Changes Made:
Email Input Type Defined:
Improved Error Messaging:
react-toastify. This enhancement provides a better user experience by clearly indicating errors and successful actions in a more visually appealing way.Implementation Details:
react-toastifyto display toast messages for various scenarios:ToastContainercomponent in the respective components to ensure that the toasts are rendered.Testing:
Screenshots:
Conclusion:
These changes enhance the form validation and user feedback on the signup and login pages, providing a smoother and more intuitive user experience. I look forward to feedback and am confident that this fix will improve the overall usability of the application.
Please let me know if there are any additional changes or details needed.