update popart api to sdk2.3 & remove custom erf ,already use popart o… (#655) (#656)

* update popart api to sdk2.3 & remove custom erf ,already use popart origin erf

Co-authored-by: yanwei <yw01041751@alibaba-inc.com>
(cherry picked from commit 4d23a95)

Co-authored-by: yanwei-gr <yw01041751@alibaba-inc.com>

Author: weimingzha0

.github/actions/build/build_in_docker.sh

@@ -36,7 +36,7 @@ DOCKER_ID=`docker ps -aq -f name=$CONTAINER_NAME -f status=running`
 gid=$(id -g ${USER})
 group=$(id -g -n ${USER})
 uid=$(id -u ${USER})
-extra_mnt="-v /opt/poplar_sdk-ubuntu_18_04-2.2.2+711-26aba6cf16:/opt/poplar_sdk:ro"
+extra_mnt="-v /opt/poplar_sdk-ubuntu_18_04-2.3.0_774:/opt/poplar_sdk:ro"
 mkdir -p /tmp/ubuntu.cache
 extra_mnt="$extra_mnt -v /tmp/ubuntu.cache:/cache"
 

.github/workflows/main.yaml

@@ -77,7 +77,7 @@ jobs:
             $image_registry/computation/halo:$image_tag \
             /bin/bash -c 'source scl_source enable devtoolset-7 && cd /build && cmake -G Ninja /host/halo -DHALO_USE_TIDY_CHECK=OFF -DHALO_GEN_DOCS=OFF -DODLA_BUILD_POPART_USE_CXX11ABI=OFF -DODLA_BUILD_POPART_CUSTOM_OPS=ON -DODLA_BUILD_TRT=OFF -DODLA_BUILD_XNNPACK=OFF -DODLA_BUILD_EIGEN=OFF -DODLA_BUILD_DNNL=OFF -DHALO_BUILD_RTLIB=OFF -DHALO_USE_STATIC_PROTOBUF=ON -DCPACK_SYSTEM_NAME=centos-i686 && ninja && source /opt/poplar_sdk/poplar/enable.sh && ninja check-halo && ninja package && cp /build/*.bz2 /build/*.rpm /host/output_centos'
         env:
-          poplar_sdk: /opt/poplar_sdk-centos_7_6-2.2.2+711-26aba6cf16
+          poplar_sdk: /opt/poplar_sdk-centos_7_6-2.3.0_774
           repo_name : heterogeneity-aware-lowering-and-optimization
           image_registry : registry-intl.us-west-1.aliyuncs.com
           image_tag : latest-devel-x86_64-centos7

ODLA/platforms/odla_popart/CMakeLists.txt

@@ -35,7 +35,7 @@ set(POPART_ROOT ${POPART_ROOT} PARENT_SCOPE)
 
 list(APPEND CMAKE_PREFIX_PATH ${POPLAR_ROOT})
 list(APPEND CMAKE_PREFIX_PATH ${POPART_ROOT})
-find_package(popart 2.2.1... REQUIRED CONFIG COMPONENTS popart-only REQUIRED)
+find_package(popart 2.3.0... REQUIRED CONFIG COMPONENTS popart-only REQUIRED)
 
 message(STATUS "Found popart, version: ${popart_VERSION}")
 

ODLA/platforms/odla_popart/custom_ops/CMakeLists.txt

@@ -15,7 +15,6 @@
 # ==============================================================================
 
 add_odla_library(custom_ops SHARED
-  erf.cc
   rsqrt.cc
   postprocess.cc
   attention_mask.cc

ODLA/platforms/odla_popart/custom_ops/rsqrt.cc

@@ -59,17 +59,18 @@ static popart::OpCreator<RsqrtOp> rsqrtOpCreator(popart::OpDefinitions({
 class RsqrtOpx : public popart::popx::ElementWiseUnaryOpx {
  public:
   RsqrtOpx(popart::Op*, popart::popx::Devicex*);
-  void grow(poplar::program::Sequence&) const final;
+  void grow(snap::program::Sequence&) const final;
 };
 
 RsqrtOpx::RsqrtOpx(popart::Op* op, popart::popx::Devicex* devicex)
     : popart::popx::ElementWiseUnaryOpx(op, devicex) {
   verifyOp<RsqrtOp>(op, CustomOperators::Rsqrt_1);
 }
 
-void RsqrtOpx::grow(poplar::program::Sequence & prog) const {
+void RsqrtOpx::grow(snap::program::Sequence & prog) const {
   auto result = popops::map(graph().getPoplarGraph(), popops::expr::UnaryOpType::RSQRT,
-                              getInTensor(0).getPoplarTensor(), prog, debugContext());
+                              getInTensor(0).getPoplarTensor(), prog.getPoplarSequence(),
+							  debugContext());
   setOutTensor(0, snap::Tensor{result, graph()});
 }