[ODLA][Async] Add status as callback argument

Author: Weiming Zhao

ODLA/platforms/odla_popart/odla_compute.cc

@@ -85,7 +85,8 @@ odla_status odla_SetContextItem(odla_context context, odla_item_type type,
   }
   switch (type) {
     case ODLA_ASYNC_CALLBACK_FUNC:
-      context->async_callback_func = reinterpret_cast<void (*)(void*)>(value);
+      context->async_callback_func =
+          reinterpret_cast<void (*)(void*, odla_status)>(value);
       break;
     case ODLA_ASYNC_CALLBACK_ARG:
       context->async_callback_arg = reinterpret_cast<void*>(value);

ODLA/platforms/odla_popart/odla_pipeline.h

@@ -216,7 +216,8 @@ struct _odla_pipeline_async_context : public _odla_pipeline_context {
           this);
       throw std::invalid_argument("async_callback_arg is null");
     }
-    async_callback_func(async_callback_arg);
+    async_callback_func(async_callback_arg,
+                        ODLA_SUCCESS); // FIXME: notify the status
   }
   bool hold(const std::string& function_name) override { return true; }
 };

ODLA/platforms/odla_popart/odla_popart.h

@@ -176,7 +176,7 @@ struct _odla_context {
   odla_computation comp;
   std::map<popart::TensorId, std::unique_ptr<popart::IArray>> inputs;
   std::map<popart::TensorId, std::unique_ptr<popart::IArray>> outputs;
-  void (*async_callback_func)(void*) = nullptr;
+  void (*async_callback_func)(void*, odla_status) = nullptr;
   void* async_callback_arg = nullptr;
   _odla_context(odla_computation c) : comp(c) {}
   std::thread::id thread_id_of_holder;

lib/target/generic_cpp/generic_cxx_codegen.cc

@@ -626,7 +626,7 @@ void GenericCXXCodeGen::RunOnFunction(Function& function) {
       oss << "extern \"C\" {\n";
     }
     if (opts_.emit_code_for_async) {
-      oss << "  typedef int (*model_run_callback)(void *);\n";
+      oss << "  typedef int (*model_run_callback)(void *, odla_status);\n";
     }
     oss << "  " << func_decl << ";\n";
     oss << "int " << init_func_name << "();\n";