[ODLA/DNNL]resize support nhwc #241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weimingzha0
reviewed
Mar 22, 2021
| return SinkTranspose( | ||
| *inst, [new_shape, inst](IRBuilder& builder, const std::string& name, | ||
| const Def& op) { | ||
| auto new_inst = builder.CreateResize(name, {op, *new_shape}); | ||
| new_inst->CopyAttrsFrom(*inst); | ||
| new_inst->SetAxesMask(-1); |
There was a problem hiding this comment.
For NCHW, the masks are (0011), for NHWC, the masks are (0110). So there it should permute the bits for axe mask
|
|
||
| float scale_h; | ||
| float scale_w; | ||
| std::vector<float> scales = {1.0f, 1.0f, 1.0f, 1.0f}; |
There was a problem hiding this comment.
here it can check each bit of axes_mask. if I-th bit is 0, scales[I] = 1
we don't need to worry about nhwc/nchw.
| @@ -1348,11 +1348,28 @@ odla_value odla_Resize(odla_value input, odla_interpolation_mode interpolation, | |||
| auto input_md = input->mem.get_desc(); | |||
| auto dt = input->mem.get_desc().data_type(); | |||
|
|
|||
| auto ret_md = dnnl::memory::desc(getDims(output_dims), dt, | |||
| dnnl::memory::format_tag::nchw); | |||
| auto format_tag = dnnl::memory::format_tag::nchw; | |||
There was a problem hiding this comment.
ret_md should be the same format_tag as input_md.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.