Issue-1026: Prevent Errors When Using VideoPress Videos #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinfodness
added
bug
kevinfodness
changed the title
kevinfodness
deleted the
fix/issue-1026/videopress-embed-image-parser
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1026
This pull request addresses the issue with VideoPress embedded videos causing a
FAILED_TO_PARSE_IMAGEerror when publishing to Apple News. The fix involves removing theis_embed_figurecheck from the image parser and removing the associated function entirely, as it is incorrectly used and not appropriate for images.Changes Made
is_embed_figurecheck from the image parser.is_embed_figurefunction, as it was only used in one incorrect instance.Steps to Test
FAILED_TO_PARSE_IMAGEerror no longer occurs.Additional Notes
Because of how VideoPress works, it's not straightforward to implement first-class support for the videos (Apple News requires a Video component and a direct link to an MP4 file to play, whereas VideoPress relies on JavaScript and iframes to play videos). The goal for this PR is to stop getting component errors on the image component when a VideoPress embed is encountered.