From 0d2638ec25408ec5546bd2cc067bab83ef302d48 Mon Sep 17 00:00:00 2001
From: Matthias Seitz <matthias.seitz@outlook.de>
Date: Tue, 18 Feb 2025 09:00:32 +0100
Subject: [PATCH] chore: misc clippy

---
 crates/evm/src/eth.rs    | 1 -
 crates/op-evm/src/lib.rs | 7 +++----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/crates/evm/src/eth.rs b/crates/evm/src/eth.rs
index 7d606c2..436aa1e 100644
--- a/crates/evm/src/eth.rs
+++ b/crates/evm/src/eth.rs
@@ -121,7 +121,6 @@ where
         contract: Address,
         data: Bytes,
     ) -> Result<ResultAndState, Self::Error> {
-        #[allow(clippy::needless_update)] // side-effect of optimism fields
         let tx = TxEnv {
             caller,
             kind: TxKind::Call(contract),
diff --git a/crates/op-evm/src/lib.rs b/crates/op-evm/src/lib.rs
index dba3c83..349c82c 100644
--- a/crates/op-evm/src/lib.rs
+++ b/crates/op-evm/src/lib.rs
@@ -7,6 +7,8 @@
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 #![cfg_attr(not(feature = "std"), no_std)]
 
+extern crate alloc;
+
 use alloc::vec::Vec;
 use alloy_evm::{Database, Evm, EvmEnv, EvmFactory};
 use alloy_primitives::{Address, Bytes, TxKind, U256};
@@ -26,8 +28,6 @@ use revm_optimism::{
     DefaultOp, OpBuilder, OpContext, OpHaltReason, OpSpecId, OpTransaction, OpTransactionError,
 };
 
-extern crate alloc;
-
 /// OP EVM implementation.
 #[allow(missing_debug_implementations)] // missing revm::OpContext Debug impl
 pub struct OpEvm<DB: Database, I> {
@@ -105,7 +105,6 @@ where
         contract: Address,
         data: Bytes,
     ) -> Result<ResultAndState<Self::HaltReason>, Self::Error> {
-        #[allow(clippy::needless_update)] // side-effect of optimism fields
         let tx = OpTransaction {
             base: TxEnv {
                 caller,
@@ -174,9 +173,9 @@ impl EvmFactory<EvmEnv<OpSpecId>> for OpEvmFactory {
     type Evm<DB: Database, I: Inspector<OpContext<DB>>> = OpEvm<DB, I>;
     type Context<DB: Database> = OpContext<DB>;
     type Tx = OpTransaction<TxEnv>;
-    type HaltReason = OpHaltReason;
     type Error<DBError: core::error::Error + Send + Sync + 'static> =
         EVMError<DBError, OpTransactionError>;
+    type HaltReason = OpHaltReason;
 
     fn create_evm<DB: Database>(
         &self,