Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated key lint from manifests #456

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove deprecated key lint from manifests #456

wants to merge 1 commit into from

Conversation

emhane
Copy link
Collaborator

@emhane emhane commented Feb 26, 2025

@emhane emhane added the A-meta Area: Changes in contributor experience label Feb 26, 2025
@mattsse
Copy link
Member

mattsse commented Feb 26, 2025

I think this an edition2024 thing, so can also hold off here

@emhane
Copy link
Collaborator Author

emhane commented Feb 26, 2025

I think this an edition2024 thing, so can also hold off here

yes and need to double check if this fix is actually needed, seems like maybe root cause of this deny check error was edition mismatch

@emhane emhane added the C-blocked Category: This cannot move forward until something else changes label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@refcell refcell Awaiting requested review from refcell refcell is a code owner

@clabby clabby Awaiting requested review from clabby clabby is a code owner

Assignees
No one assigned
Labels
A-meta Area: Changes in contributor experience C-blocked Category: This cannot move forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse