Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump msrv to 1.85 #457

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bump msrv to 1.85 #457

wants to merge 3 commits into from

Conversation

emhane
Copy link
Collaborator

@emhane emhane commented Feb 26, 2025

Bumps MSRV to 1.85

@emhane emhane added the C-deps Category: Dependencies label Feb 26, 2025
mattsse
mattsse approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me but iirc @clabby flagged some msrv issues on kona coming from other teams, so we should hold off here until we checked

@emhane emhane force-pushed the emhane/bump-rust-version branch 2 times, most recently from 553caa8 to f8cddcf Compare February 26, 2025 15:06
@emhane
feat(l2-withdrawals-root): Add conversions for OpExecutionData (#455)
61d1441 
- Adds missing variant `OpExecutionPayload::V1`, needed to support
conversion from `ExecutionPayloadInputV2`
- Fixes buggy `as_mut` methods for `OpExecutionPayload`
- Adds conversion from `newPayload` args to `OpExecutionData`
@emhane emhane force-pushed the emhane/bump-rust-version branch from f8cddcf to 61d1441 Compare February 26, 2025 15:13
@clabby
Copy link
Collaborator

clabby commented Feb 26, 2025

fine with me but iirc @clabby flagged some msrv issues on kona coming from other teams, so we should hold off here until we checked

Yeah, we need to wait on this unfortunately. The RiscZero zkVM toolchain is getting to 1.83 by EOW, and SP-1's is on 1.82 iirc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@refcell refcell Awaiting requested review from refcell refcell is a code owner

@clabby clabby Awaiting requested review from clabby clabby is a code owner

Assignees
No one assigned
Labels
C-deps Category: Dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emhane @clabby @mattsse