Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update nightly #45

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: update nightly #45

wants to merge 2 commits into from

Conversation

storopoli
Copy link
Member

Description

Despite rust-lang/rust#133199 (comment) saying that:

The "fix" is to add #![feature(generic_const_exprs)] to the top of every crate that depends on your crate, and to the top of every doctest.

it does not work.

I tried the approach that I add #![feature(generic_const_exprs)] to every crate and doctest in the strata-bridge then keep removing one-by-one until I cannot.

I thought that it would be easier to find the minimal satisfiable set of #![feature(generic_const_exprs)].

Yet, somehow this does not work and I triple-checked that I added in everything that has a nested Cargo.toml.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Leaving this open if someone has a better idea or insight.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

@Rajil1213
Copy link
Collaborator

Looks like the issue is because the generics in the bitvm repo are not local. The most straightforward solution is to bring all the contents of the bitvm::signatures::wots_api to strata-bridge-primitives.

Here's the source:

https://github.com/alpenlabs/BitVM/blob/f7fd93e9c9187100e7c9b7b68e07f9f7c568a843/bitvm/src/signatures/wots_api.rs

@storopoli
Copy link
Member Author

Looks like the issue is because the generics in the bitvm repo are not local. The most straightforward solution is to bring all the contents of the bitvm::signatures::wots_api to strata-bridge-primitives.

Here's the source:

https://github.com/alpenlabs/BitVM/blob/f7fd93e9c9187100e7c9b7b68e07f9f7c568a843/bitvm/src/signatures/wots_api.rs

Tried to do that in d23b0e5 but to no avail. I am hitting this now in #46 will revert the strata-p2p back to 2024-11-01 nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants