Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of fixes for calling the new deploy.yml workflow. #15

Merged
merged 2 commits into from
May 14, 2024

Conversation

sengi
Copy link
Contributor

@sengi sengi commented May 14, 2024

  • Remove leftover default param that made it easy to accidentally build+deploy main. Makes it the same as all the other repos.
  • Make the tag refs work the same as all the other repos.

Turns out I picked the one repo that had an outdated version of these boilerplate workflow-calling workflows. Sigh.

#10

sengi added 2 commits May 14, 2024 12:55
This makes it work the same as all the rest.
Same as alphagov/frontend@5775b9d.

Missed from deb038d because it turns out the pattern repo I used
(search-api-v2) had an outdated copy. I'll fix that in a followup.
@sengi sengi requested a review from samsimpson1 May 14, 2024 12:01
@sengi
Copy link
Contributor Author

sengi commented May 14, 2024

alphagov/search-api-v2#270 is the same fix for the repo I used as the template in #13.

@sengi sengi merged commit 30e0041 into main May 14, 2024
2 checks passed
@sengi sengi deleted the sengi/fix-default-rollout-params branch May 14, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants