Reduce GitHub workflow runs (including Percy screenshot uploads) #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
colinrotherham
force-pushed
the
reduce-percy-usage
branch
from
1a00454 to
57f07fa
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
colinrotherham
force-pushed
the
reduce-percy-usage
branch
from
da06036 to
6cd237a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
colinrotherham
force-pushed
the
reduce-percy-usage
branch
from
6cd237a to
f36e812
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
colinrotherham
force-pushed
the
reduce-percy-usage
branch
from
f36e812 to
2694631
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
colinrotherham
force-pushed
the
reduce-percy-usage
branch
from
2694631 to
fb25ee2
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
colinrotherham
force-pushed
the
reduce-percy-usage
branch
from
fb25ee2 to
4c2142c
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
colinrotherham
changed the title
colinrotherham
force-pushed
the
reduce-percy-usage
branch
from
4c2142c to
dc34836
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
colinrotherham
force-pushed
the
reduce-percy-usage
branch
from
dc34836 to
ad9dfa0
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
colinrotherham
changed the title
colinrotherham
force-pushed
the
reduce-percy-usage
branch
from
ad9dfa0 to
f5135a2
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
colinrotherham
force-pushed
the
reduce-percy-usage
branch
from
f5135a2 to
fba630d
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
|
@36degrees Morning! This commit for “JavaScript disabled” screenshots follows your idea in #2871 I've added a |
Prevents duplicate runs as `pull_request` event already fires for PR pushes
By removing `push` events we’ve lost the abilty to run tests without a PR being open, not any more
When tests were run with the Node.js or jsdom test environment, we were including helper code that tried to access the Puppeteer `page` object
Makes sure we’re also testing the default environment for all components
Previously the Sass rendering tests were combined with the screenshot generation `describe()` block
colinrotherham
force-pushed
the
reduce-percy-usage
branch
from
34dad96 to
f1182b3
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
colinrotherham
force-pushed
the
reduce-percy-usage
branch
from
f1182b3 to
de727f2
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
|
Morning @36degrees I've gone through and split out all the commits, explaining what's happening and why If you can take another look please 😊 |
Reloads the page (without JavaScript) for second capture
…test.js` These tests don’t need a Chromium browser window (Puppeteer environment) This change brings Nunjucks HTML render + validation together
These tests don’t need a Chromium browser window (Puppeteer environment)
We’ve configured Jest + Puppeteer with `browserPerWorker: true` to open multiple browsers and speed up our tests: https://github.com/smooth-code/jest-puppeteer#jest-puppeteerconfigjs This stops Node.js warning us about potential memory leaks
…isting()`
Preparation for tests that need to filter components by certain files, for example “All components with `${component}.mjs`”
This change reduces our Percy screenshots down from 64 to 42 as we don’t need to capture identical screenshots for components that lack JavaScript functionality
colinrotherham
force-pushed
the
reduce-percy-usage
branch
from
de727f2 to
83736b7
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2878
36degrees
approved these changes
Sep 30, 2022
Open
1 task
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding some GitHub Action workflow tweaks here
Ideas so far
Cancel in-progress GitHub workflows when pushed again
Forgot a change? Pushing up a second time with cancel the 1st test run
Remove
pushevent from GitHub Actions branch workflowsPrevents duplicate runs as
pull_requestevent already fires for PR pushesSkip tests for documentation changesDon't need to run JavaScript tests when onlydocs/**/*.mdfiles have changed (??)Move “All components” template tests out of Puppeteer environment
Don't lose time spinning up Chromium (headless) to run HTML validation checks etc
Only take “JavaScript disabled” screenshots for components with JS
Skip "JavaScript disabled" tests for components lacking
*.mjsfiles as screenshots will be identicalBefore
[pull_request, push]events for PRsGitHub Workflow: 14 checks total (7 checks per run)
Screenshots (JavaScript enabled): 64 images (32 per run)
Screenshots (JavaScript disabled): 64 images (32 per run)
Time: 89.322 s, estimated 96 sAfter
pull_requestevents for PRsGitHub Workflow: 7 checks total
Percy screenshots (JavaScript enabled): 32 images
Percy screenshots (JavaScript disabled): 11 images
Time: 58.233 s, estimated 96 s