Do not raise when a webhook worker experiences a remote server error #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
changed the title
brucebolt
force-pushed
the
do-not-log-server-error
branch
from
664bc0d to
7b53217
Compare
JonathanHallam
approved these changes
Apr 2, 2024
This application returns the link checking results to the requesting application through a webhook. In some cases, the remote server will respond with an error (e.g. a timeout or some other 5xx status code). We don't need to log these to Sentry, since they are outside of this application's control. Therefore rescuing from the `Faraday::ServerError` raise that can occur in this worker.
brucebolt
force-pushed
the
do-not-log-server-error
branch
from
7b53217 to
edc1aa9
Compare
|
Thanks @JonathanHallam. Would you mind looking again, since I forgot to commit the test 🤦♂️! |
JonathanHallam
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This application returns the link checking results to the requesting application through a webhook.
In some cases, the remote server will respond with an error (e.g. a timeout). We don't need to log these to Sentry, since they are outside of this application's control.
Therefore rescuing from the
Faraday::ServerErrorraise that can occur in this worker.Trello card