Specifically report where Cloudflare block our requests #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
improve-cloudflare-reports
branch
from
49edb18 to
ce0e271
Compare
In the `has errors` shared test example, we were passing in a string to check against the errors but not actually checking it. This meant you could add any string and the test would always pass, provided an error existed. Therefore updating the shared example to actually accept a parameter, check the error is returned and update the messages to reflect what the class is actually returning to users.
brucebolt
force-pushed
the
improve-cloudflare-reports
branch
from
ce0e271 to
ef5892b
Compare
Some linked websites use [Cloudflare Browser Integrity Check](https://developers.cloudflare.com/waf/tools/browser-integrity-check/) to stop automated robots from accessing their site. This works by responding with a 403 status code and a payload that contains some JavaScript. The JavaScript carries out some checks before reloading the page with a 200 status code. Our crawler is unable to interact with the JavaScript, so Cloudflare block our access to the site. In order to stop users thinking these links are actually broken, this change reports a different warning (not an error) when we are blocked by Cloudflare.
brucebolt
force-pushed
the
improve-cloudflare-reports
branch
from
ef5892b to
93073c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some linked websites use Cloudflare Browser Integrity Check to stop automated robots from accessing their site.
This works by responding with a 403 status code and a payload that contains some JavaScript. The JavaScript carries out some checks before reloading the page with a 200 status code.
Our crawler is unable to interact with the JavaScript, so Cloudflare block our access to the site.
In order to stop users thinking these links are actually broken, this change reports a different error when we are blocked by Cloudflare.
Trello card