Skip to content

Commit

Permalink
Unskip test now that edit state for published editions is merged
Browse files Browse the repository at this point in the history
  • Loading branch information
ellohez authored and PeterHattyar committed Mar 5, 2025
1 parent aadf4da commit 9b0c980
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 3 additions & 3 deletions test/functional/notes_controller_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class NotesControllerTest < ActionController::TestCase

assert_equal(@note_text, @edition.important_note.comment)
assert_redirected_to history_edition_path(@edition)
assert_includes flash[:success], "Note recorded"
assert_equal "Note recorded", flash[:success]
end

should "show 'Note resolved' if a parent note exists and then an empty note is saved" do
Expand All @@ -91,7 +91,7 @@ class NotesControllerTest < ActionController::TestCase

assert_nil(@edition.important_note)
assert_redirected_to history_edition_path(@edition)
assert_includes flash[:success], "Note resolved"
assert_equal "Note resolved", flash[:success]
end

should "show no flash message if no parent note exists and then an empty note is saved" do
Expand Down Expand Up @@ -124,7 +124,7 @@ class NotesControllerTest < ActionController::TestCase
@edition.reload

assert_redirected_to history_update_important_note_edition_path(@edition)
assert_includes flash[:danger], "Note failed to save"
assert_equal "Note failed to save", flash[:danger]
end
end

Expand Down
2 changes: 0 additions & 2 deletions test/integration/edition_edit_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,7 @@ class EditionEditTest < IntegrationTest
# New asserts go here
end

# TODO: Test to be switched on when the "Create new edition" functionality has been implemented.
should "not be carried forward to new editions" do
skip "Until this functionality is complete: #601 - Edit page for Published edition (answer and help)"
note_text = "This important note should not appear on a new edition."
create_published_edition
create_important_note_for_edition(@published_edition, note_text)
Expand Down

0 comments on commit 9b0c980

Please sign in to comment.