557 history notes tab update important note

[ellohez]

Trello card

The changes have added an Update Important Note function with button, to the side bar, visible from the History and Notes tab

Scenario	View
User visits the History and notes tab on an Artefact, the Update Important Note button is present, also on display is a present Important Note on the document which is always visible regardless of which tab the user is on.
User clicks on Update Important Note button, the page populates the editing textbox with the existing note inside present to adjust or remove.
User clears the important note in the edit textbox and clicks save. The message informs the user this has been successful, the note has been cleared, so an important note is no longer visible on the page.
User edits the existing note or enters new text into the textbox and clicks save. The message informs the user that this has been successfully saved.

[mtaylorgds]

Nice work, just a couple of very minor comments.

[davidtrussler]

Is it worth adding a test that these two text elements are within a banner (and likewise below)?
So maybe

within :css, ".govuk-notification-banner" do
  assert page.has_text?("Important")
  assert page.has_text?(note_text)
end

[davidtrussler]

Nice work - LGTM! 👍

[mtaylorgds]

Minor assertion tweak suggestion