Move Users table to postgres #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syed-ali-tw
force-pushed
the
p-o-p-b-migrate-user
branch
3 times, most recently
from
5a62e61 to
6619772
Compare
Tetrino
approved these changes
Feb 24, 2025
mtaylorgds
reviewed
Feb 25, 2025
syed-ali-tw
force-pushed
the
p-o-p-b-migrate-user
branch
3 times, most recently
from
dc5102c to
616e353
Compare
syed-ali-tw
force-pushed
the
publisher-on-postgres-branch
branch
from
d4798df to
7b2874a
Compare
syed-ali-tw
force-pushed
the
p-o-p-b-migrate-user
branch
21 times, most recently
from
7724d74 to
a33499b
Compare
syed-ali-tw
force-pushed
the
p-o-p-b-migrate-user
branch
16 times, most recently
from
b94eb56 to
ae4d417
Compare
mtaylorgds
reviewed
Feb 25, 2025
app/lib/govuk_content_models/action_processors/assign_processor.rb
Outdated
Show resolved
Hide resolved
syed-ali-tw
force-pushed
the
p-o-p-b-migrate-user
branch
from
ae4d417 to
5509369
Compare
mtaylorgds
reviewed
Feb 26, 2025
syed-ali-tw
force-pushed
the
p-o-p-b-migrate-user
branch
from
5509369 to
b2cb490
Compare
mtaylorgds
approved these changes
Feb 27, 2025
baisa
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move User table to postgres and support any existing relation with other models using temporary foreign key.
All the temporary code changes are earmarked with comments to allow assistance when we would undo them.
Note: there is a test failure on test/models/edition_test.rb: should "have a database-level constraint on the uniqueness"
This has been hard to debug, the test passes locally and will change in near future, hence investing any more time trying to fix it might not be worth it.
Follow these steps if you are doing a Rails upgrade.