Skip to content

Commit 275a403

Browse files
committed
Merge remote-tracking branch 'origin/main' into feature/add-format-string-support
# Conflicts: # packages/use-intl/src/core/createFormatter.tsx # packages/use-intl/test/core/createFormatter.test.tsx
2 parents 656e701 + 0ad3bb2 commit 275a403

File tree

234 files changed

+9072
-2710
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

234 files changed

+9072
-2710
lines changed

.github/ISSUE_TEMPLATE/bug_report.yml renamed to .github/ISSUE_TEMPLATE/01_bug_report.yml

+13-7
Original file line numberDiff line numberDiff line change
@@ -18,27 +18,33 @@ body:
1818
1. `next-intl` is based on Next.js, therefore bugs in Next.js might cause errors in apps that use `next-intl`. Please make sure that the bug you're experiencing is _caused by_ by `next-intl`. If you're unsure, please search on [the Next.js issue tracker](https://github.com/vercel/next.js/issues) for similar issues.
1919
2. General usage questions are not bug reports. Please [submit usage questions on Stack Overflow](https://stackoverflow.com/questions/ask) instead.
2020
3. Bug reports without a reproduction may be closed immediately.
21-
22-
If you need help with a specific problem in your project, you can consider getting [paid support](https://github.com/sponsors/amannn?frequency=one-time) instead.
2321
- type: textarea
2422
attributes:
2523
label: Description
2624
description: A clear and concise description of what the bug is.
2725
validations:
2826
required: true
27+
- type: checkboxes
28+
attributes:
29+
label: Verifications
30+
options:
31+
- label: I've verified that the problem I'm experiencing isn't covered in [the docs](https://next-intl-docs.vercel.app/).
32+
required: true
33+
- label: I've searched for similar, existing issues on GitHub and [Stack Overflow](https://stackoverflow.com/search?q=next-intl).
34+
required: true
35+
- label: I've compared my app to [a working example](https://next-intl-docs.vercel.app/examples) to look for differences.
36+
required: true
2937
- type: input
3038
attributes:
31-
label: Mandatory reproduction URL (CodeSandbox or GitHub repository)
39+
label: Mandatory reproduction URL
3240
description: |
33-
**Templates:**
34-
- [CodeSandbox (App Router)](https://codesandbox.io/p/sandbox/next-intl-bug-template-app-forked-zcymvq)
35-
- [CodeSandbox (Pages Router)](https://codesandbox.io/p/sandbox/next-intl-bug-template-pages-krm37f)
41+
**Templates:** [App Router](https://github.com/amannn/next-intl-bug-repro-app-router), [Pages Router](https://github.com/amannn/next-intl/tree/main/examples/example-pages-router)
3642
validations:
3743
required: true
3844
- type: textarea
3945
attributes:
4046
label: Reproduction description
41-
description: Describe how the issue can be reproduced based on your provided CodeSandbox or GitHub repository.
47+
description: Describe how the issue can be observed based on your provided reproduction.
4248
value: |
4349
Steps to reproduce:
4450
1. Open reproduction

.github/ISSUE_TEMPLATE/config.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
blank_issues_enabled: false
22
contact_links:
3-
- name: Get paid support
4-
url: https://github.com/sponsors/amannn?frequency=one-time
5-
about: Book a consulting session to get help with your specific project
63
- name: View documentation
74
url: https://next-intl-docs.vercel.app/
85
about: Check out the official docs for answers to common questions
9-
- name: Ask a question
6+
- name: Get community support
107
url: https://stackoverflow.com/questions/ask
118
about: Ask questions and discuss with other community members
9+
- name: Get maintainer support
10+
url: https://github.com/sponsors/amannn?frequency=one-time
11+
about: Book a consulting session to get help with your specific project

.github/workflows/close-stale.yml

+12-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,16 @@ jobs:
1313
steps:
1414
- uses: actions/stale@v8
1515
with:
16-
days-before-stale: 7
16+
days-before-stale: 14
1717
days-before-close: 0
18-
any-of-labels: reproduction-missing
19-
stale-issue-message: "This issue has been automatically closed because it is missing a reproduction and there hasn't been any activity for 7 days. If the problem persists, please create a new bug report."
18+
any-of-labels: reproduction-missing,needs-isolation
19+
stale-issue-message: "This issue has been automatically closed because it is currently not actionable and has become stale. If the problem persists, please create a new issue."
20+
close-stale:
21+
runs-on: ubuntu-latest
22+
steps:
23+
- uses: actions/stale@v8
24+
with:
25+
days-before-stale: 30
26+
days-before-close: 0
27+
any-of-labels: unconfirmed
28+
stale-issue-message: "This issue has been automatically closed because there was no recent activity and it was marked as unconfirmed. Note that issues are regularly checked and if they remain in unconfirmed state, they might miss information required to be actionable or are potentially out-of-scope. If you'd like to discuss this topic further, feel free to open a discussion instead."

.github/workflows/issue-commenter.yml

+23-10
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
types:
55
- labeled
66
jobs:
7-
add-comment:
7+
reproduction-missing:
88
if: github.event.label.name == 'reproduction-missing'
99
runs-on: ubuntu-latest
1010
permissions:
@@ -14,13 +14,13 @@ jobs:
1414
with:
1515
issue-number: ${{ github.event.issue.number }}
1616
body: |
17-
Thank you for your report.
17+
Thank you for your report!
1818
1919
Unfortunately, the reproduction is missing or incomplete, and as such we cannot investigate this issue. Please add a reproduction to the issue, otherwise it will be closed automatically.
2020
2121
**Templates:**
22-
- [CodeSandbox (App Router)](https://codesandbox.io/p/sandbox/next-intl-bug-template-app-forked-zcymvq)
23-
- [CodeSandbox (Pages Router)](https://codesandbox.io/p/sandbox/next-intl-bug-template-pages-krm37f)
22+
- [App Router](https://github.com/amannn/next-intl-bug-repro-app-router)
23+
- [Pages Router](https://github.com/amannn/next-intl/tree/main/examples/example-pages-router)
2424
2525
**Creating a good bug report takes time.**
2626
@@ -39,10 +39,23 @@ jobs:
3939
4040
**"I've included a reproduction, what is missing?"**
4141
42-
This comment might have been added because your reproduction doesn't point to either a CodeSandbox or a public GitHub repository where the issue can be reproduced.
43-
44-
Please make sure:
45-
1. If you've linked to a CodeSandbox, make sure to save the latest changes.
46-
2. If you've linked to a GitHub repository, make sure that you've committed and pushed the latest changes.
47-
3. Linking to other resources, e.g. to the docs, unfortunately doesn't help to reproduce your issue.
42+
This comment might have been added because your reproduction doesn't point to a destination where the issue can be reproduced. Please make sure that the latest changes were saved in the reproduction and that the link is correct.
4843
</details>
44+
45+
needs-isolation:
46+
if: github.event.label.name == 'needs-isolation'
47+
runs-on: ubuntu-latest
48+
permissions:
49+
issues: write
50+
steps:
51+
- uses: peter-evans/create-or-update-comment@v3
52+
with:
53+
issue-number: ${{ github.event.issue.number }}
54+
body: |
55+
Thank you for your report!
56+
57+
From the currently available context in this issue, it's unclear wether the erroneous behavior is caused by Next.js, `next-intl` or a 3rd party library that you're using. Please isolate the issue further to be sure that the issue is _caused_ by `next-intl`. When in doubt, please search on [the Next.js issue tracker](https://github.com/vercel/next.js/issues) or related resources of 3rd party libraries you might be using.
58+
59+
If you're able to isolate the issue to `next-intl`, please provide a minimal reproduction that ideally doesn't involve any 3rd party libraries or alternatively demonstrates that `next-intl` is causing the issue.
60+
61+
Thank you for your understanding!

.github/workflows/publish.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
# Seems like after squash & merge the author is unknown to lerna
2626
- run: git config --global user.email "jan@amann.work" && git config --global user.name "Jan Amann"
2727
- run: pnpm run publish
28-
if: "${{!startsWith(github.event.head_commit.message, 'docs: ')}}"
28+
if: "${{startsWith(github.event.head_commit.message, 'fix: ') || startsWith(github.event.head_commit.message, 'feat: ')}}"
2929
env:
3030
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3131
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

0 commit comments

Comments
 (0)