docs: Adjust locale switcher example to provide more type safety #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amannn
commented
Aug 14, 2024
| // @ts-expect-error -- TypeScript will validate that only known `params` | ||
| // are used in combination with a given `pathname`. Since the two will | ||
| // always match for the current route, we can skip runtime checks. | ||
| params |
There was a problem hiding this comment.
By moving the directive here, we keep the validation that an object can be received by router.replace. In case of shared pathnames, this will show an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
LocaleSwitcherSelectinexample-app-routerto match docs #853