Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove unused import #1806

Merged
merged 2 commits into from
Mar 21, 2025
Merged

docs: Remove unused import #1806

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
149bcbe
chore(docs): update with-i18n-routing.mdx
pnodet Mar 20, 2025
3b9e6c9
Apply suggestions from code review
amannn Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions docs/src/pages/docs/getting-started/app-router/with-i18n-routing.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,17 +220,15 @@ const withNextIntl = createNextIntlPlugin(
The `locale` that was matched by the middleware is available via the `locale` param and can be used to configure the document language. Additionally, we can use this place to pass configuration from `i18n/request.ts` to Client Components via `NextIntlClientProvider`.

```tsx filename="app/[locale]/layout.tsx"
import {NextIntlClientProvider, Locale, hasLocale} from 'next-intl';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, the Locale import was indeed unused!

import {NextIntlClientProvider, hasLocale} from 'next-intl';
import {notFound} from 'next/navigation';
import {routing} from '@/i18n/routing';
import type { PropsWithChildren } from 'react';

export default async function LocaleLayout({
children,
params
}: {
children: React.ReactNode;
params: Promise<{locale: string}>;
}) {
}: PropsWithChildren<{ readonly params: Promise<{ locale: string }> }) {
// Ensure that the incoming `locale` is valid
const {locale} = await params;
if (!hasLocale(routing.locales, locale)) {
Expand Down