Skip to content

update: move next turbo config from experimental to top level #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sakib412
Copy link

@sakib412 sakib412 commented Apr 10, 2025

Ref: #1838

Copy link

vercel bot commented Apr 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-intl-example-app-router ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 9:29am
next-intl-example-app-router-without-i18n-routing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 9:29am

Copy link

vercel bot commented Apr 10, 2025

@sakib412 is attempting to deploy a commit to the next-intl Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sakib412
Copy link
Author

This would unfortunately be a breaking change for users on Next.js <15.3.

Please see the previous discussion here:

Got you! Either we have to wait for to get the nextjs version in next config or we can pass the nextjs version in

createNextIntlPlugin('path', options = {nextVersion: '15.3.0'})

function arg as options. (we can parse the version from package.json or node_modules)
and also this is just a warning we can ignore for now, anyway nextjs will release major version for breaking change.

@amannn
Copy link
Owner

amannn commented Apr 10, 2025

we can parse the version from package.json or node_modules

I thought about that too, but I'm afraid there could be edge cases. E.g., can we make an assumption about where a package.json file should be? E.g. Next.js supports the [directory] argument for next dev, therefore process.cwd() could be somewhere else.

The closest I could think of would be to use require.resolve('next') to get a path to the Next.js dependency folder and from there traverse upwards to find the closest package.json and read the version from there.

It sounds a bit hairy though and maybe there are edge cases. So ideally, Next.js would help a bit here, let's see if we can get support from them in vercel/next.js#78009.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants