Skip to content

Use next_slice for row-column info prevention instead of reset #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
desaikd opened this issue Feb 13, 2025 · 0 comments
Open

Use next_slice for row-column info prevention instead of reset #906

desaikd opened this issue Feb 13, 2025 · 0 comments

Comments

@desaikd
Copy link
Contributor

desaikd commented Feb 13, 2025

This is a follow-up issue on winnow-rs/winnow#742

Current approach in TextBuffer uses the reset API to preserve row and column information. Although reset is currently being used in lot of places which could lead to future issues if they change the way reset gets used.

We should rather rely on having this prevention logic in next_slice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@desaikd