-
-
Notifications
You must be signed in to change notification settings - Fork 105
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cases for this action over official Vercel git integration? #103
Comments
Hi @leerob! I just want to share my use case for this action with you. We have our NodeJS application in a private GitHub repository. Also, it is using the NPM package with another private GitHub repository as a source. To install this package I need an SSH key to be present in the SSH agent. Right now it's not possible with Vercel itself. See more in this issue - https://github.com/vercel/vercel/discussions/5274 So, we've decided to use GitHub Actions + this vercel-action to build the application correctly and publish it to Vercel. I hope, it makes sense. |
@vadym-vorobel thank you, that's very helpful 😄 |
Hi @leerob |
@leerob I second @dszymczuk Also, if I only have 1 member on the Vercel team, none of the PR's made by my GH team members are deployed. I don't want to add my whole team just for the reason of deployment. We're a team of 4. That'd be $80 / month to let them deploy. |
Clarity and consistency. When everything related to CI is in one area, has its own structure and is managed by one technology. And not mashed into different interfaces that don't depend on you, work somehow differently, and can change to the worse at any moment. |
I'm using it to get around the monorepo limit that Vercel has. I have actions that run on changes to each deployable app in Github. Just like that...no more arbitrary limit. Thank you! |
@brandonarbini Thanks for sharing! Would you mind elaborating on which limit you mean exactly? |
@leo It means that if have monorepo (fe. 3 projects in one folder), you can't initialize 3 independent projects in each folder. You can initialize vercel project only on the root folder. |
@dszymczuk That's an interesting issue – thanks for sharing it! But this issue right here is about why the GitHub Action would be used instead of our Git Integration, not about development. Perhaps @brandonarbini is talking about how every Git repository on Vercel can only be connected to a fixed number of projects within a single Vercel Personal Account or Team? |
Yep, there are some limitations that I need to get around like the max of 3 projects for personal accounts and 10 for teams. I prefer to work in a monorepo for my personal projects and I have more than 3 there. Also, I just saw the "ignored build step" feature that wasn't there when I was getting things running initially. That will help a lot because I don't like building everything on every push. Ultimately, the limit of 3 on personal is limiting and upgrading to a team plan for $20/mo seems unnecessary since I only deploy changes to these projects very occasionally. |
I see. That makes a lot of sense, thank you! I'll bring this up to the team too. |
@leerob Hi there! My setup was too far off the platonic project shape and I was unable to get the build to work with the official git integration to work.
|
@leerob Thanks for asking! After moving my project to a monorepo I needed to disable the git integration I was using for starters. I second everything @daiyi mentioned, but I'll add a couple things:
IMO, I think the Vercel CLI is still very helpful (for this kind of automation). I feel the Vercel "no-config" model works for base cases, but as projects need more features (or integrations with custom API cases), this can get tricky, and a good independent CI/CD deployment model (that can push to Vercel when required) is key. To that end, IMO Vercel could better support advanced cases by allowing developers the flexibility to:
|
Suggestion to move this to a GitHub discussion - but @amondnet must activate discussions in this repository first. GitHub issues should be for specific bugs/ problems. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Hello! I'd love to hear more about what this action aims to solve that the official Vercel git integration does not.
We'd had some confusion since this is not a official Vercel solution and I'd love to have some clarity. Thank you!
https://vercel.com/docs/git
The text was updated successfully, but these errors were encountered: