Extract common code from UvFile and EioFile into an internal abstract class

Author: trowski

src/Driver/EioFile.php

@@ -6,33 +6,17 @@
 use Amp\ByteStream\StreamException;
 use Amp\Cancellation;
 use Amp\DeferredFuture;
-use Amp\File\File;
 use Amp\File\Internal;
 use Amp\File\PendingOperationError;
 use Amp\Future;
-use function Amp\async;
 
-final class EioFile implements File
+final class EioFile extends Internal\QueuedWritesFile
 {
     private readonly Internal\EioPoll $poll;
 
     /** @var resource eio file handle. */
     private $fh;
 
-    private string $path;
-
-    private string $mode;
-
-    private int $size;
-
-    private int $position;
-
-    private \SplQueue $queue;
-
-    private bool $isReading = false;
-
-    private bool $writable = true;
-
     private ?Future $closing = null;
 
     private readonly DeferredFuture $onClose;
@@ -42,22 +26,14 @@ final class EioFile implements File
      */
     public function __construct(Internal\EioPoll $poll, $fh, string $path, string $mode, int $size)
     {
+        parent::__construct($path, $mode, $size);
+
         $this->poll = $poll;
         $this->fh = $fh;
-        $this->path = $path;
-        $this->mode = $mode;
-        $this->size = $size;
-        $this->position = ($mode[0] === "a") ? $size : 0;
 
-        $this->queue = new \SplQueue;
         $this->onClose = new DeferredFuture;
     }
 
-    public function __destruct()
-    {
-        async($this->close(...));
-    }
-
     public function read(?Cancellation $cancellation = null, int $length = self::DEFAULT_READ_LENGTH): ?string
     {
         if ($this->isReading || !$this->queue->isEmpty()) {
@@ -116,35 +92,6 @@ public function read(?Cancellation $cancellation = null, int $length = self::DEF
         }
     }
 
-    public function write(string $bytes): void
-    {
-        if ($this->isReading) {
-            throw new PendingOperationError;
-        }
-
-        if (!$this->writable) {
-            throw new ClosedException("The file is no longer writable");
-        }
-
-        if ($this->queue->isEmpty()) {
-            $future = $this->push($bytes, $this->position);
-        } else {
-            $position = $this->position;
-            /** @var Future $future */
-            $future = $this->queue->top()->map(fn () => $this->push($bytes, $position)->await());
-        }
-
-        $this->queue->push($future);
-
-        $future->await();
-    }
-
-    public function end(): void
-    {
-        $this->writable = false;
-        $this->close();
-    }
-
     public function close(): void
     {
         if ($this->closing) {
@@ -177,71 +124,7 @@ public function onClose(\Closure $onClose): void
         $this->onClose->getFuture()->finally($onClose);
     }
 
-    public function truncate(int $size): void
-    {
-        if ($this->isReading) {
-            throw new PendingOperationError;
-        }
-
-        if (!$this->writable) {
-            throw new ClosedException("The file is no longer writable");
-        }
-
-        if ($this->queue->isEmpty()) {
-            $future = $this->trim($size);
-        } else {
-            $future = $this->queue->top()->map(fn () => $this->trim($size)->await());
-        }
-
-        $this->queue->push($future);
-
-        $future->await();
-    }
-
-    public function seek(int $position, int $whence = \SEEK_SET): int
-    {
-        if ($this->isReading) {
-            throw new PendingOperationError;
-        }
-
-        switch ($whence) {
-            case self::SEEK_SET:
-                $this->position = $position;
-                break;
-            case self::SEEK_CUR:
-                $this->position += $position;
-                break;
-            case self::SEEK_END:
-                $this->position = $this->size + $position;
-                break;
-            default:
-                throw new \Error("Invalid whence parameter; SEEK_SET, SEEK_CUR or SEEK_END expected");
-        }
-
-        return $this->position;
-    }
-
-    public function tell(): int
-    {
-        return $this->position;
-    }
-
-    public function eof(): bool
-    {
-        return $this->queue->isEmpty() && $this->size <= $this->position;
-    }
-
-    public function getPath(): string
-    {
-        return $this->path;
-    }
-
-    public function getMode(): string
-    {
-        return $this->mode;
-    }
-
-    private function push(string $data, int $position): Future
+    protected function push(string $data, int $position): Future
     {
         $length = \strlen($data);
 
@@ -292,7 +175,7 @@ private function push(string $data, int $position): Future
         return $deferred->getFuture();
     }
 
-    private function trim(int $size): Future
+    protected function trim(int $size): Future
     {
         $deferred = new DeferredFuture;
         $this->poll->listen();
@@ -331,19 +214,4 @@ private function trim(int $size): Future
 
         return $deferred->getFuture();
     }
-
-    public function isReadable(): bool
-    {
-        return !$this->isClosed();
-    }
-
-    public function isSeekable(): bool
-    {
-        return !$this->isClosed();
-    }
-
-    public function isWritable(): bool
-    {
-        return $this->writable;
-    }
 }