Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: WebExperiment class #152

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

feat: WebExperiment class #152

wants to merge 40 commits into from

Conversation

tyiuhc
Copy link
Collaborator

@tyiuhc tyiuhc commented Jan 2, 2025

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

tyiuhc and others added 28 commits November 5, 2024 11:51
@tyiuhc
update doFlags to take user object, update tag script to fetch remote…
34c2cb6 
… flags
@tyiuhc
fix applyVariants logic
a463740
@tyiuhc
create remote flag fetch test and clean up exisiting tests
348d857
@tyiuhc
refactor unit tests code
936f27a
@tyiuhc
add unit tests
27b71cd
@tyiuhc
update unit tests, update getFlags with deliveryMethod arg
987031e
@tyiuhc
fix lint
f729fe4
@tyiuhc
fix tests
a93d63a
@tyiuhc
fix doFlags
6a91800
@tyiuhc
fix web remote eval preview unit test
d8a5109
@tyiuhc
remove unused util
c40f7ed
@tyiuhc
remove unused import
7db6dd4
@tyiuhc
fix doFlags user creation
2285a9d
@tyiuhc
fix web_exp_id generation for backwards compatability
eea5ef4
@tyiuhc
nit: formatting
a379647
@tyiuhc
refactor parsing initial flags, add antiflicker for remote blocking f…
a2ad01e 
…lags
@tyiuhc
update getflags options, exclude x-amp-exp-user header when no user/d…
bfce7c6 
…evice id, make doFlags private
@tyiuhc
Merge branch 'main' into web-remote-eval
1a72974
@tyiuhc
fix: test
ac60b53
@tyiuhc
refactor and add comment for setting IDs
e8b064f
@tyiuhc
make all remote flags locally evaluable, only applyVariants present i…
c8bd924 
…n initialFlags
@tyiuhc
feat: modularized WebExperiment class
b83f131
@tyiuhc
update tests
4ffb6fa
@tyiuhc
Add additional methods
ba6e8b8
@tyiuhc
Refactor and add additional methods
718f02a
@tyiuhc
Additional tests and config
73cd67f
@tyiuhc
update tests
99ad580
@tyiuhc
update with index
4cdabc7
@tyiuhc tyiuhc marked this pull request as draft January 2, 2025 23:46
bgiori
bgiori requested changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@bgiori bgiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review, will review more soon.

packages/experiment-tag/src/experiment.ts Outdated Show resolved Hide resolved
packages/experiment-tag/src/experiment.ts Outdated Show resolved Hide resolved
packages/experiment-tag/src/experiment.ts Outdated Show resolved Hide resolved
packages/experiment-tag/src/experiment.ts Outdated Show resolved Hide resolved
packages/experiment-tag/src/experiment.ts Outdated Show resolved Hide resolved
packages/experiment-tag/src/experiment.ts Outdated Show resolved Hide resolved
packages/experiment-tag/src/experiment.ts Outdated Show resolved Hide resolved
packages/experiment-tag/src/experiment.ts Outdated Show resolved Hide resolved
Base automatically changed from web-remote-eval to main January 6, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgiori bgiori bgiori requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyiuhc @bgiori