Skip to content

Add byte order detection for internal SHA1 implementation for MacOS, POWER, RISC-V and s390 #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2024

Conversation

marty1885
Copy link
Collaborator

This is a fix for drogonframework/drogon#2065. Currently byte order is SHA1 is not defined on MacOS. This is only a problem if no TLS provider is present.

@marty1885 marty1885 requested a review from an-tao June 15, 2024 17:23
@marty1885 marty1885 changed the title add macOS byte order defination to SHA1 Add byte order detection for internal SHA1 implementation for MacOS, POWER, RISC-V and s390 Jun 16, 2024
@marty1885
Copy link
Collaborator Author

This PR depends on #340 to be merged first

@an-tao an-tao merged commit 0131da9 into master Jun 16, 2024
33 checks passed
@marty1885 marty1885 deleted the fix-sha1-macos branch June 16, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants