[Security Solution] [Attack discovery] Removes technical preview badge (

elastic#209876) ### [Security Solution] [Attack discovery] Removes technical preview badge This PR removes the _Technical preview_ badge from the Attack discovery page title, as illustrated by the `Before` and `After` screenshots below: **Before** ![title_before](https://github.com/user-attachments/assets/b8510b19-52e1-4c7c-acdf-1c81366a00d8) _Above: The page title contains a technical preview badge (before this change)_ **After** ![title_after](https://github.com/user-attachments/assets/399206c2-1f71-4c18-908d-6ef9f36d61ae) _Above: The page title does NOT contain a technical preview badge (after this change)_ #### Details This PR should be merged **after** the PR to remove the _Alerts filtering_ feature flag is merged: <elastic#209851> #### Desk testing 1. Navigate to Security > Attack discovery **Expected result** - The Attack discovery page title does NOT include the technical preview badge
andrew-goldstein · Feb 21, 2025 · 8701a39 · 8701a39
1 parent 70ece10
commit 8701a39
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 111 deletions.
diff --git a/x-pack/platform/plugins/private/translations/translations/fr-FR.json b/x-pack/platform/plugins/private/translations/translations/fr-FR.json
@@ -7486,8 +7486,6 @@
     "securitySolutionPackages.navigation.landingLinks": "Vues de sécurité",
     "securitySolutionPackages.sideNav.betaBadge.label": "Bêta",
     "securitySolutionPackages.sideNav.togglePanel": "Activer/Désactiver le panneau de navigation",
-    "securitySolutionPackages.upselling.pages.attackDiscovery.pageTitle.betaBadge": "Version d'évaluation technique",
-    "securitySolutionPackages.upselling.pages.attackDiscovery.pageTitle.betaTooltip": "Cette fonctionnalité est en version d’évaluation technique, elle est susceptible d’être modifiée. Veuillez utiliser Attack Discovery avec prudence dans les environnements de production.",
     "securitySolutionPackages.upselling.pages.attackDiscovery.pageTitle.pageTitle": "Attack discovery",
     "securitySolutionPackages.upselling.sections.attackDiscovery.findPotentialAttacksWithAiTitle": "Trouvez les attaques potentielles grâce à l'IA",
     "share.advancedSettings.csv.quoteValuesText": "Les valeurs doivent-elles être mises entre guillemets dans les exportations CSV ?",
@@ -34211,8 +34209,6 @@
     "xpack.securitySolution.attackDiscovery.pages.noAlerts.attackDiscoveryOnlyLabel": "Attack Discovery analyse uniquement les alertes des dernières 24 heures.",
     "xpack.securitySolution.attackDiscovery.pages.noAlerts.learnMoreLink": "En savoir plus sur Attack discovery",
     "xpack.securitySolution.attackDiscovery.pages.noAlerts.noAlertsToAnalyzeTitle": "Aucune alerte à analyser",
-    "xpack.securitySolution.attackDiscovery.pages.pageTitle.betaBadge": "Version d'évaluation technique",
-    "xpack.securitySolution.attackDiscovery.pages.pageTitle.betaTooltip": "Cette fonctionnalité est en version d’évaluation technique, elle est susceptible d’être modifiée. Veuillez utiliser Attack Discovery avec prudence dans les environnements de production.",
     "xpack.securitySolution.attackDiscovery.pages.pageTitle.pageTitle": "Attack discovery",
     "xpack.securitySolution.attackDiscovery.pages.pageTitle.statusConnectors": "Vous avez {newDiscoveriesCount} {newDiscoveriesCount, plural, =1 {nouvelle découverte} other {nouvelles découvertes}} à travers {newConnectorResultsCount} {newConnectorResultsCount, plural, =1 {connecteur} other {connecteurs}} à examiner.",
     "xpack.securitySolution.attackDiscovery.pages.welcome.firstSetUpLabel": "Tout d’abord, configurez un connecteur d’IA générative.",

diff --git a/x-pack/platform/plugins/private/translations/translations/ja-JP.json b/x-pack/platform/plugins/private/translations/translations/ja-JP.json
@@ -7363,8 +7363,6 @@
     "securitySolutionPackages.navigation.landingLinks": "セキュリティビュー",
     "securitySolutionPackages.sideNav.betaBadge.label": "ベータ",
     "securitySolutionPackages.sideNav.togglePanel": "パネルナビゲーションを切り替える",
-    "securitySolutionPackages.upselling.pages.attackDiscovery.pageTitle.betaBadge": "テクニカルプレビュー",
-    "securitySolutionPackages.upselling.pages.attackDiscovery.pageTitle.betaTooltip": "この機能はテクニカルプレビュー中で、変更される可能性があります。Attack Discoveryは、本番環境では注意して使用してください。",
     "securitySolutionPackages.upselling.pages.attackDiscovery.pageTitle.pageTitle": "Attack discovery",
     "securitySolutionPackages.upselling.sections.attackDiscovery.findPotentialAttacksWithAiTitle": "AIを利用して潜在的な攻撃を検出",
     "share.advancedSettings.csv.quoteValuesText": "csvエクスポートに値を引用するかどうかです",
@@ -34073,8 +34071,6 @@
     "xpack.securitySolution.attackDiscovery.pages.noAlerts.attackDiscoveryOnlyLabel": "Attack Discoveryは過去24時間のアラートのみを分析します。",
     "xpack.securitySolution.attackDiscovery.pages.noAlerts.learnMoreLink": "Attack discoveryの詳細",
     "xpack.securitySolution.attackDiscovery.pages.noAlerts.noAlertsToAnalyzeTitle": "分析するアラートがありません",
-    "xpack.securitySolution.attackDiscovery.pages.pageTitle.betaBadge": "テクニカルプレビュー",
-    "xpack.securitySolution.attackDiscovery.pages.pageTitle.betaTooltip": "この機能はテクニカルプレビュー中で、変更される可能性があります。Attack Discoveryは、本番環境では注意して使用してください。",
     "xpack.securitySolution.attackDiscovery.pages.pageTitle.pageTitle": "Attack discovery",
     "xpack.securitySolution.attackDiscovery.pages.pageTitle.statusConnectors": "{newConnectorResultsCount} {newConnectorResultsCount, plural, other {コネクター}}全体で、表示する{newDiscoveriesCount}件の新しい{newDiscoveriesCount, plural, other {検出}}があります。",
     "xpack.securitySolution.attackDiscovery.pages.welcome.firstSetUpLabel": "まず、生成AIコネクターを設定します。",

diff --git a/x-pack/platform/plugins/private/translations/translations/zh-CN.json b/x-pack/platform/plugins/private/translations/translations/zh-CN.json
@@ -7252,8 +7252,6 @@
     "securitySolutionPackages.navigation.landingLinks": "安全视图",
     "securitySolutionPackages.sideNav.betaBadge.label": "公测版",
     "securitySolutionPackages.sideNav.togglePanel": "切换面板导航",
-    "securitySolutionPackages.upselling.pages.attackDiscovery.pageTitle.betaBadge": "技术预览",
-    "securitySolutionPackages.upselling.pages.attackDiscovery.pageTitle.betaTooltip": "此功能处于技术预览状态，可能会进行更改。在生产环境中请谨慎使用 Attack Discovery。",
     "securitySolutionPackages.upselling.pages.attackDiscovery.pageTitle.pageTitle": "Attack Discovery",
     "securitySolutionPackages.upselling.sections.attackDiscovery.findPotentialAttacksWithAiTitle": "利用 AI 发现潜在攻击",
     "share.advancedSettings.csv.quoteValuesText": "在 CSV 导出中是否应使用引号引起值？",
@@ -33545,8 +33543,6 @@
     "xpack.securitySolution.attackDiscovery.pages.noAlerts.attackDiscoveryOnlyLabel": "Attack Discovery 仅分析过去 24 小时的告警。",
     "xpack.securitySolution.attackDiscovery.pages.noAlerts.learnMoreLink": "详细了解 Attack Discovery",
     "xpack.securitySolution.attackDiscovery.pages.noAlerts.noAlertsToAnalyzeTitle": "没有要分析的告警",
-    "xpack.securitySolution.attackDiscovery.pages.pageTitle.betaBadge": "技术预览",
-    "xpack.securitySolution.attackDiscovery.pages.pageTitle.betaTooltip": "此功能处于技术预览状态，可能会进行更改。在生产环境中请谨慎使用 Attack Discovery。",
     "xpack.securitySolution.attackDiscovery.pages.pageTitle.pageTitle": "Attack Discovery",
     "xpack.securitySolution.attackDiscovery.pages.pageTitle.statusConnectors": "您具有 {newDiscoveriesCount} 个新{newDiscoveriesCount, plural, other {发现}}可跨 {newConnectorResultsCount} 个{newConnectorResultsCount, plural, other {连接器}}查看。",
     "xpack.securitySolution.attackDiscovery.pages.welcome.firstSetUpLabel": "首先设置生成式 AI 连接器。",

diff --git a/...ck/solutions/security/packages/upselling/pages/attack_discovery/page_title/index.test.tsx b/...ck/solutions/security/packages/upselling/pages/attack_discovery/page_title/index.test.tsx
@@ -21,10 +21,4 @@ describe('PageTitle', () => {
 
     expect(attackDiscoveryPageTitle).toHaveTextContent(ATTACK_DISCOVERY_PAGE_TITLE);
   });
-
-  it('renders the beta badge icon', () => {
-    const betaBadge = screen.getByTestId('betaBadge');
-
-    expect(betaBadge).toBeInTheDocument();
-  });
 });
diff --git a/x-pack/solutions/security/packages/upselling/pages/attack_discovery/page_title/index.tsx b/x-pack/solutions/security/packages/upselling/pages/attack_discovery/page_title/index.tsx
@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { EuiBetaBadge, EuiFlexGroup, EuiFlexItem, EuiTitle, useEuiTheme } from '@elastic/eui';
+import { EuiTitle, useEuiTheme } from '@elastic/eui';
 import { css } from '@emotion/react';
 import React from 'react';
 
@@ -15,35 +15,15 @@ const PageTitleComponent: React.FC = () => {
   const { euiTheme } = useEuiTheme();
 
   return (
-    <EuiFlexGroup
-      alignItems="center"
-      data-test-subj="pageTitle"
-      gutterSize="none"
-      responsive={false}
-      wrap={true}
+    <EuiTitle
+      css={css`
+        margin-bottom: ${euiTheme.size.s};
+      `}
+      data-test-subj="attackDiscoveryPageTitle"
+      size="l"
     >
-      <EuiFlexItem grow={false}>
-        <EuiTitle data-test-subj="attackDiscoveryPageTitle" size="l">
-          <h1>{i18n.ATTACK_DISCOVERY_PAGE_TITLE}</h1>
-        </EuiTitle>
-      </EuiFlexItem>
-
-      <EuiFlexItem
-        css={css`
-          margin: ${euiTheme.size.s} 0 0 ${euiTheme.size.m};
-        `}
-        grow={false}
-      >
-        <EuiBetaBadge
-          color="hollow"
-          data-test-subj="betaBadge"
-          iconType={'beaker'}
-          label={i18n.BETA}
-          tooltipContent={i18n.BETA_TOOLTIP}
-          size="m"
-        />
-      </EuiFlexItem>
-    </EuiFlexGroup>
+      <h1>{i18n.ATTACK_DISCOVERY_PAGE_TITLE}</h1>
+    </EuiTitle>
   );
 };
 

diff --git a/...k/solutions/security/packages/upselling/pages/attack_discovery/page_title/translations.ts b/...k/solutions/security/packages/upselling/pages/attack_discovery/page_title/translations.ts
@@ -13,18 +13,3 @@ export const ATTACK_DISCOVERY_PAGE_TITLE = i18n.translate(
     defaultMessage: 'Attack discovery',
   }
 );
-
-export const BETA = i18n.translate(
-  'securitySolutionPackages.upselling.pages.attackDiscovery.pageTitle.betaBadge',
-  {
-    defaultMessage: 'Technical preview',
-  }
-);
-
-export const BETA_TOOLTIP = i18n.translate(
-  'securitySolutionPackages.upselling.pages.attackDiscovery.pageTitle.betaTooltip',
-  {
-    defaultMessage:
-      'This functionality is in technical preview and is subject to change. Please use Attack Discovery with caution in production environments.',
-  }
-);
diff --git a/...ons/security/plugins/security_solution/public/attack_discovery/pages/page_title/index.tsx b/...ons/security/plugins/security_solution/public/attack_discovery/pages/page_title/index.tsx
@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { EuiBetaBadge, EuiFlexGroup, EuiFlexItem, EuiTitle, useEuiTheme } from '@elastic/eui';
+import { EuiTitle, useEuiTheme } from '@elastic/eui';
 import { css } from '@emotion/react';
 import React from 'react';
 
@@ -15,40 +15,15 @@ const PageTitleComponent: React.FC = () => {
   const { euiTheme } = useEuiTheme();
 
   return (
-    <EuiFlexGroup
-      alignItems="center"
-      data-test-subj="pageTitle"
-      gutterSize="none"
-      responsive={false}
-      wrap={true}
+    <EuiTitle
+      css={css`
+        margin-bottom: ${euiTheme.size.s};
+      `}
+      data-test-subj="attackDiscoveryPageTitle"
+      size="l"
     >
-      <EuiFlexItem grow={false}>
-        <EuiTitle data-test-subj="attackDiscoveryPageTitle" size="l">
-          <h1>{i18n.ATTACK_DISCOVERY_PAGE_TITLE}</h1>
-        </EuiTitle>
-      </EuiFlexItem>
-
-      <EuiFlexItem
-        css={css`
-          margin: ${euiTheme.size.m} 0 0 ${euiTheme.size.m};
-        `}
-        grow={false}
-      >
-        <EuiBetaBadge
-          iconType={'beaker'}
-          label={i18n.BETA}
-          tooltipContent={i18n.BETA_TOOLTIP}
-          size="m"
-          color="hollow"
-          css={css`
-            .euiBetaBadge__icon {
-              position: relative;
-              top: 5px;
-            }
-          `}
-        />
-      </EuiFlexItem>
-    </EuiFlexGroup>
+      <h1>{i18n.ATTACK_DISCOVERY_PAGE_TITLE}</h1>
+    </EuiTitle>
   );
 };
 

diff --git a/...curity/plugins/security_solution/public/attack_discovery/pages/page_title/translations.ts b/...curity/plugins/security_solution/public/attack_discovery/pages/page_title/translations.ts
@@ -13,18 +13,3 @@ export const ATTACK_DISCOVERY_PAGE_TITLE = i18n.translate(
     defaultMessage: 'Attack discovery',
   }
 );
-
-export const BETA = i18n.translate(
-  'xpack.securitySolution.attackDiscovery.pages.pageTitle.betaBadge',
-  {
-    defaultMessage: 'Technical preview',
-  }
-);
-
-export const BETA_TOOLTIP = i18n.translate(
-  'xpack.securitySolution.attackDiscovery.pages.pageTitle.betaTooltip',
-  {
-    defaultMessage:
-      'This functionality is in technical preview and is subject to change. Please use Attack Discovery with caution in production environments.',
-  }
-);