Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of commit_unknown_results #1

Open
andrewchambers opened this issue Jan 21, 2023 · 0 comments
Open

Improve handling of commit_unknown_results #1

andrewchambers opened this issue Jan 21, 2023 · 0 comments

Comments

@andrewchambers
Copy link
Owner

andrewchambers commented Jan 21, 2023

There are a few places where retry of commit_unknown_results errors causes problems:

We unlinked a file, we retry on commit_unknown_results then the file is not found causing a spurious error. It seems to me in this situation one sensible solution is an io error and not a file not found error. To solve this fully we might need to associate a token with the unlink operation so we can make unlink idempotent.

We created a file and retry on commit_unknown_results, this will cause a spurious file already exists error - this case is easily solved by checking if the file that exists has the inode we are trying to create - inodes are unique in hafs.

We renamed a file and retry oncommit_unknown_results, this will cause a spurious file not found error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant