flash-from-device: remove extraneous dependencies on stdenv tools #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The
flash-from-devicescript was inadvertently bringing in all stdenv tools available in therunCommanditself. The $PATH here wasn't intended to be substituted in therunCommand, but rather when running the script itself! Consequently, the/nix/storeoutput forflash-from-devicehad references tocoreutils,gnused,gnugrep, etc. present in this line.It turns out this $PATH wasn't necessary at all, since all required tools to run
flash-from-deviceare already present inpkgsStatic.busyboxandstaticDeps, so I'm removing it.This decreases the size of an Orin AGX devkit initrd from 47M down to 25M.
Testing
Flashed an Orin AGX devkit