Skip to content

Commit fcad35c

Browse files
blackwolf12333mportuga
authored andcommitted
fix: clearSelectedRows should respect enableSelection
The issue we had was that we have rows that are selected, but also have enableSelection: false. We expected select all to behave similarly when selecting and unselecting all rows in that select all does not touch disabled rows. But unselect all does touch disabled rows. This fixes the above issue by using the same check that is used during select all behavior in clearSelectedRows.
1 parent 715e59b commit fcad35c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/selection/src/js/selection.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,7 @@
627627
clearSelectedRows: function (grid, evt) {
628628
var changedRows = [];
629629
service.getSelectedRows(grid).forEach(function (row) {
630-
if (row.isSelected) {
630+
if (row.isSelected && row.enableSelection !== false && grid.options.isRowSelectable(row) !== false) {
631631
row.setSelected(false);
632632
service.decideRaiseSelectionEvent(grid, row, changedRows, evt);
633633
}

0 commit comments

Comments
 (0)