Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add initial workflow for adev build #927

Merged
merged 18 commits into from
Jul 13, 2024
Merged

chore: add initial workflow for adev build #927

merged 18 commits into from
Jul 13, 2024

Conversation

lacolaco
Copy link
Collaborator

@lacolaco lacolaco commented Jul 11, 2024

Adding initial workflows for adev build and deploy.

Copy link

cloudflare-workers-and-pages bot commented Jul 11, 2024

Deploying dev-angular-jp with  Cloudflare Pages  Cloudflare Pages

Latest commit: ab697d3
Status: ✅  Deploy successful!
Preview URL: https://093a935d.dev-angular-jp.pages.dev
Branch Preview URL: https://18-1-x.dev-angular-jp.pages.dev

View logs

@lacolaco lacolaco changed the title wip: adev chore: add initial workflow for adev build Jul 13, 2024
Comment on lines 55 to 62
script: |
const prNumber = process.env.PR_NUMBER;
github.issues.createComment({
issue_number: ${{ github.event.workflow_run.head_branch }},
owner: context.repo.owner,
repo: context.repo.repo,
body: 'Preview deployed to https://pr-${prNumber}.dev-angular-jp.pages.dev'
})

Check failure

Code scanning / CodeQL

Expression injection in Actions Critical

Potential injection from the ${{ github.event.workflow_run.head_branch }}, which may be controlled by an external user.
@lacolaco lacolaco marked this pull request as ready for review July 13, 2024 15:45
@lacolaco lacolaco merged commit fa83b76 into main Jul 13, 2024
6 checks passed
@lacolaco lacolaco deleted the 18.1.x branch July 13, 2024 15:46
@lacolaco lacolaco added this to the adev milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant