ci: update adev-preview-deployment to no longer use metadata from build output #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacolaco
reviewed
Sep 26, 2024
| - name: Deploy to Firebase Hosting Preview | ||
| id: firebase-deploy | ||
| uses: FirebaseExtended/action-hosting-deploy@v0.9.0 | ||
| with: | ||
| repoToken: "${{ secrets.GITHUB_TOKEN }}" | ||
| firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT }}" | ||
| projectId: angular-ja | ||
| channelId: pr-${{ steps.pr-number.outputs.value }} | ||
| channelId: pr-${{ github.event.workflow_run.pull_requests.number }} |
There was a problem hiding this comment.
I wonder how the line here works because GHA documentation says workflow_run.pull_requests is typed as an array of objects.
https://docs.github.com/en/webhooks/webhook-events-and-payloads#workflow_run
@josephperrott Have you seen other repositories that uses workflow_run.pull_requests.number like here?
There was a problem hiding this comment.
After looking closer into it, it seems that it won't work with this method of extraction, additionally it seems that if a change comes from a fork then it won't provide the pull request at all. So I reverted back to how it was extracted before.
…ld output Use the github event values instead of the user generated information.
josephperrott
force-pushed
the
update-action
branch
from
eb33bcf to
1bdbf2d
Compare
lacolaco
approved these changes
Sep 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the github event values instead of the user generated information.