-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
if (!toc.items.some(isBrowser)) { | ||
return Promise.reject('Generated toc.json missing docs for Protractor function.'); | ||
} | ||
// TODO: dtw - find out what this browser check is really for. May be obsolete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd not want to disable build time checks
<h2>What does End Of Life mean?</h2> | ||
The packages will remain accessible on GitHub, npm, Bower, and Release archive. This website will also remain here indefinitely. The project will be archived on GitHub and remain accessible indefinitely, but will no longer be open to issues / comments / etc. | ||
|
||
<h2>Support After August 2023</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the page to look like? https://docs.angularjs.org/misc/version-support-status
Extended Long Term Support
If you need extended support for Protractor, you should consider:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgechev given that HeroDevs is supporting protractor for an additional year at no cost, it seems that it makes sense to explain the free year of NES here. I feel like that would make sense. Should we have a call to talk about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left suggestions inline
Given the website is currently deployed off the 5.4 branch, I migrated the work to #5560. All the comments should be addressed, but feel free to raise any issue there. |
With Protractor becoming LTS and given the partnership with HeroDevs to provide support past August 2023, we had discussed adding documentation to explain what the future holds.
Happy to collaborate on the messaging, style, or any other aspect! We just wanted to take a swing at it to help with the lift!
Screen shot of change:

Note: This PR builds on #5556 (as it was required to run the site for review)