Skip to content

Commit 1c1e7a4

Browse files
committed
fix: duplicate non piggies in response to piggies/users/
1 parent ff90cfc commit 1c1e7a4

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

piggies/views.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ def list(self, request):
4545
piggies = Piggies.objects.filter(username=username)
4646
serializer = PiggiesSerializer(piggies, many=True)
4747
final_users = []
48+
piggies_id = [str(pig["piggy"]) for pig in serializer.data]
4849

49-
for pig in serializer.data:
50-
for user in filtered_users:
51-
if str(pig["piggy"]) == user["user_id"]:
52-
final_users.append(user)
50+
for user in filtered_users:
51+
if user["user_id"] in piggies_id:
52+
final_users.append(user)
5353

5454
return Response(data=final_users)
5555
except Piggies.DoesNotExist:
@@ -118,11 +118,11 @@ def users(self, request):
118118
return Response(data=filtered_users)
119119

120120
final_users = []
121+
piggies_id = [str(pig["piggy"]) for pig in serializer.data]
121122

122-
for pig in serializer.data:
123-
for user in filtered_users:
124-
if str(pig["piggy"]) != user["user_id"]:
125-
final_users.append(user)
123+
for user in filtered_users:
124+
if user["user_id"] not in piggies_id:
125+
final_users.append(user)
126126

127127
return Response(data=final_users)
128128
except Exception as e:

0 commit comments

Comments
 (0)