Skip to content

Fix - Bidirectional unpaid debt history #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions debt/services/debt_services.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from django.contrib.auth import get_user_model
from datetime import timedelta
from django.utils import timezone
from django.db.models import Q

User = get_user_model()

Expand Down Expand Up @@ -64,15 +65,22 @@ def toggle_debt_payment(debt_id):
raise ValueError("Debt not found")


def get_unpaid_debts_by_week(user_id):
def get_unpaid_debts_by_week(user_id, piggy_id):
now = timezone.now()
start_of_week = (now - timedelta(days=now.weekday())).replace(hour=0, minute=0, second=0, microsecond=0)
start_of_last_week = start_of_week - timedelta(weeks=1)

present_week_debts = Debt.objects.filter(user__user_id=user_id, is_paid=False, created_at__gte=start_of_week)
present_week_debts = Debt.objects.filter(
(Q(user__user_id=user_id) | Q(user__user_id=piggy_id)), is_paid=False, created_at__gte=start_of_week
)
last_week_debts = Debt.objects.filter(
user__user_id=user_id, is_paid=False, created_at__gte=start_of_last_week, created_at__lt=start_of_week
(Q(user__user_id=user_id) | Q(user__user_id=piggy_id)),
is_paid=False,
created_at__gte=start_of_last_week,
created_at__lt=start_of_week,
)
previous_debts = Debt.objects.filter(
(Q(user__user_id=user_id) | Q(user__user_id=piggy_id)), is_paid=False, created_at__lt=start_of_last_week
)
previous_debts = Debt.objects.filter(user__user_id=user_id, is_paid=False, created_at__lt=start_of_last_week)

return present_week_debts, last_week_debts, previous_debts
2 changes: 1 addition & 1 deletion debt/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def toggle_payment(self, request, debt_id=None):
@action(detail=False, methods=["get"], url_path="unpaid-history/(?P<other_user_id>[^/.]+)")
def unpaid_history(self, request, other_user_id=None):
user_id = get_user_id_from_token(request)
present_week_debts, last_week_debts, previous_debts = get_unpaid_debts_by_week(user_id)
present_week_debts, last_week_debts, previous_debts = get_unpaid_debts_by_week(user_id, other_user_id)

response_data = {
"present_week": UnpaidDebtsHistorySerializer(present_week_debts, many=True).data,
Expand Down
Loading