Wait for GitHub to process git push before updating PR
#190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the pull request (with `gh pr edit`) right after a git push was causing the `synchronize` webhook to be fired twice. This results in GitHub Actions being started twice as well. This commit adds a check before editing a pull request that compares the current HEAD commit with the head id on GitHub. If these don't match, it means that GitHub has not yet processed the git push. We check this up to five times, waiting one second between checks. Fixes #189
annervisser
force-pushed
the
wait-for-github-to-process-git-push-before-updating-pr
branch
from
e35608f to
b7860a8
Compare
annervisser
deleted the
wait-for-github-to-process-git-push-before-updating-pr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for GitHub to process
git pushbefore updating PRUpdating the pull request (with
gh pr edit) right after a git pushwas causing the
synchronizewebhook to be fired twice. This resultsin GitHub Actions being started twice as well.
This commit adds a check before editing a pull request that compares
the current HEAD commit with the head id on GitHub. If these don't
match, it means that GitHub has not yet processed the git push.
We check this up to five times, waiting one second between checks.
Fixes #189