Skip to content

feat: refactor eslint #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
May 26, 2025
Merged

feat: refactor eslint #884

merged 31 commits into from
May 26, 2025

Conversation

prisis
Copy link
Member

@prisis prisis commented May 23, 2025

No description provided.

Copy link

coderabbitai bot commented May 23, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

106 files out of 213 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented May 23, 2025

Thank you for following the naming conventions! 🙏

});

if (packages.length > 0) {
execSync(`pnpm exec pkg-pr-new publish --comment="update" --pnpm ${packages.join(" ")}`, { stdio: "inherit" });

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
.
Copy link

pkg-pr-new bot commented May 24, 2025

Open in StackBlitz

npm i https://pkg.pr.new/anolilab/javascript-style-guide/@anolilab/eslint-config@884

commit: 4ba6bbe

prisis added 25 commits May 26, 2025 08:36
BREAKING-CHANGE: Removed support for eslint v8
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
Signed-off-by: prisis <d.bannert@anolilab.de>
- Updated Node version in .nvmrc from 18.18 to 22.
- Modified pnpm-lock.yaml to reflect updated package versions and dependencies.
- Added new files to .gitignore for Cursor rules and GitHub instructions.
- Created vitest.workspace.ts for Vitest configuration.
- Added mcp.json for MCP server configuration.
- Introduced .vscode/settings.json for VSCode settings related to ESLint and Prettier.
- Updated ESLint configuration in packages/eslint-config, including dependency upgrades and rule adjustments.
- Enhanced various ESLint rules and added new rules for React and TypeScript.
- Improved YAML configuration for pnpm-workspace.

Signed-off-by: prisis <d.bannert@anolilab.de>
…n files

- Reformatted import statements for better readability.
- Adjusted various rule configurations to enhance clarity and maintainability.
- Ensured consistent use of arrow function syntax in configuration files.
- Improved message formatting in error handling and warnings.

Signed-off-by: prisis <d.bannert@anolilab.de>
- Deleted the Babel configuration file as it is no longer needed.
- Added new scripts for linting and testing affected packages in package.json.
- Updated GitHub workflow files to improve CI processes, including changes to cache clearing and issue commenting workflows.
- Introduced a new script for publishing preview releases based on changed files.

Signed-off-by: prisis <d.bannert@anolilab.de>
- Deleted the semantic.yml file as it is no longer needed for the project.
- Added "name" fields to various project.json files for better identification of configuration packages.

Signed-off-by: prisis <d.bannert@anolilab.de>
- Updated various package dependencies in package.json to their latest versions, including @anolilab/multi-semantic-release, @commitlint packages, eslint, and others.
- Added a new script "sort-package-json" to help organize package.json files.
- Updated pnpm-lock.yaml to reflect the changes in package versions and dependencies.

Signed-off-by: prisis <d.bannert@anolilab.de>
prisis added 5 commits May 26, 2025 09:18
- Removed the unused dependency '@antfu/install-pkg' from package.json.
- Updated various dependencies in pnpm-lock.yaml to their latest versions, including '@babel/template', '@babel/parser', and '@babel/code-frame'.
- Enhanced error handling in create-config.ts to provide more informative error messages for unknown file types.

Signed-off-by: prisis <d.bannert@anolilab.de>
- Updated Node version in .nvmrc from 22 to 20.18.
- Added .gitignore file for src/typegen.d.ts in the eslint-config package.
- Adjusted ESLint configuration to use relative paths for ignored files.
- Removed unused typegen.d.ts file from eslint-config package.
- Refactored various ESLint rules for improved clarity and maintainability.

Signed-off-by: prisis <d.bannert@anolilab.de>
- Added src/utils/vitest-globals.ts to .gitignore to prevent linting errors.
- Updated ESLint configuration to ignore the newly added vitest-globals.ts file.
- Reordered build scripts in package.json for improved execution flow.

Signed-off-by: prisis <d.bannert@anolilab.de>
- Updated import paths in ESLint configuration files to use explicit file extensions.
- Expanded the list of ignored files in ESLint configuration to include test files.
- Modified test scripts in package.json to prevent failures on test run.
- Added a LICENSE.md file to the fixtures directory for compliance.
- Introduced a test timeout setting in vitest configuration for better performance.

Signed-off-by: prisis <d.bannert@anolilab.de>
@prisis prisis force-pushed the refactor-eslint branch from 18267d4 to 976fd81 Compare May 26, 2025 07:20
- Removed unnecessary blank lines in allo-allo.yaml and test.yml files to improve readability and maintain consistency in workflow definitions.

Signed-off-by: prisis <d.bannert@anolilab.de>
@prisis prisis merged commit 1b5968a into main May 26, 2025
21 of 22 checks passed
@prisis prisis deleted the refactor-eslint branch May 26, 2025 07:27
prisis added a commit that referenced this pull request May 26, 2025
BREAKING-CHANGE: updated eslint from v8 to v9
prisis pushed a commit that referenced this pull request May 26, 2025
…lab/eslint-config [16.0.0](https://github.com/anolilab/javascript-style-guide/compare/@anolilab/eslint-config@15.0.3...@anolilab/eslint-config@16.0.0) (2025-05-26)

### ⚠ BREAKING CHANGES

* updated eslint from v8 to v9

### Features

* refactor eslint ([#884](#884)) ([4703162](4703162))

### Miscellaneous Chores

* **eslint-config:** enhance eslint-config documentation and update typegen script ([191db2d](191db2d))
* **eslint-config:** update dependencies to latest versions ([2126b90](2126b90))
* update eslint-config dependencies for workspace compatibility ([84be11d](84be11d))
* update eslint-config dependencies to latest versions ([c5d267f](c5d267f))

### Continuous Integration

* fixed build workflow ([622591f](622591f))

### Dependencies

* **@anolilab/prettier-config:** upgraded to 6.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant