Skip to content

feat: refactor eslint #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
May 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
4383ec9
feat(eslint-config): update all possible rules to eslint v9 flat config
prisis Dec 22, 2024
1c82f1e
feat: more work on the configs
prisis Dec 29, 2024
7bf6160
feat: more work on the configs
prisis Dec 29, 2024
03aaa5a
feat: more work on the configs
prisis Dec 30, 2024
5c4e758
feat: more work on the configs
prisis Dec 31, 2024
0047e34
feat: more work on the configs
prisis Jan 1, 2025
21a1785
feat: more work on the configs
prisis Jan 1, 2025
8a1989b
feat: more work on the configs
prisis Jan 2, 2025
678df47
feat: more work on the configs
prisis Jan 2, 2025
71f84d6
feat: more work on the configs
prisis Jan 3, 2025
9b81217
feat: more work on the configs
prisis Jan 4, 2025
4a1402a
feat: more work on the configs
prisis Jan 6, 2025
56abf59
feat: more work on the configs
prisis Jan 6, 2025
00b8a4b
feat: more work on the configs
prisis Jan 6, 2025
d74fa66
feat: more work on the configs
prisis Jan 9, 2025
997b6d1
feat: more work on the configs
prisis Jan 9, 2025
9519abc
feat: more work on the configs
prisis Jan 10, 2025
18f1f47
feat: more work on the configs
prisis Jan 11, 2025
d46eda8
chore: updated lock file
prisis Jan 12, 2025
18971cf
chore: update dependencies and configuration files
prisis May 23, 2025
6309054
style: cs fixes
prisis May 23, 2025
331b564
style: format and consistency improvements across ESLint configuratio…
prisis May 23, 2025
8d637b7
chore: remove Babel configuration and update workflow files
prisis May 23, 2025
70d73fe
chore: remove semantic.yml and add project names to configuration files
prisis May 23, 2025
7d493e8
chore: update package dependencies and scripts
prisis May 24, 2025
7be19af
chore: update ESLint config dependencies and improve error handling
prisis May 24, 2025
fed692d
chore: update ESLint configuration and dependencies
prisis May 25, 2025
5e7c01c
chore: update ESLint configuration and scripts
prisis May 25, 2025
93443b4
chore: update ESLint configuration and improve test handling
prisis May 26, 2025
976fd81
chore: update lock
prisis May 26, 2025
4ba6bbe
chore: update GitHub workflows
prisis May 26, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .github/semantic.yml

This file was deleted.

16 changes: 0 additions & 16 deletions .github/workflows/allo-allo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,3 @@ jobs:
uses: "anolilab/workflows/.github/workflows/allo-allo.yml@main"
with:
target-repo: "anolilab/javascript-style-guide"
issue-welcome: >
It looks like this is your first issue. Welcome! 👋
One of the project maintainers will be with you as soon as possible. We
appreciate your patience. To safeguard the health of the project, please
take a moment to read our [code of conduct](https://github.com/anolilab/javascript-style-guide/blob/main/.github/CODE_OF_CONDUCT.md).
pr-welcome: >
It looks like this is your first pull request. 🎉
Thank you for your contribution! One of the project maintainers will triage
and assign the pull request for review. We appreciate your patience. To
safeguard the health of the project, please take a moment to read our
[code of conduct](https://github.com/anolilab/javascript-style-guide/blob/main/.github/CODE_OF_CONDUCT.md).
pr-merged: >
Congratulations on your first merged pull request! 🎉
Thank you for your contribution!
We appreciate your patience.
We look forward to your next contribution.
2 changes: 1 addition & 1 deletion .github/workflows/cache-clear.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ on: # yamllint disable-line rule:truthy

jobs:
cleanup-branch-cache:
uses: "anolilab/workflows/.github/workflows/cleanup-branch-cache.yml@main"
uses: "anolilab/workflows/.github/workflows/cleanup-branch-cache.yaml@main"
with:
target-repo: "anolilab/javascript-style-guide"
2 changes: 1 addition & 1 deletion .github/workflows/comment-issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
We do this because:

- There are plenty of frameworks/tools out there and we would like to ensure that every method can cover all or almost all of them.
- Every feature we add to Visulima has "costs" associated to it:
- Every feature we add to "javascript-style-guide" has "costs" associated to it:
- initial costs: design, implementation, reviews, documentation
- running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

Expand Down
39 changes: 27 additions & 12 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
matrix:
os:
- "ubuntu-latest"
node_version: ["18", "20", "21", "22"]
node_version: ["22", "23", "24"]
# On the other platforms, we only test the lts node version
include:
- os: "macos-latest"
Expand Down Expand Up @@ -87,27 +87,42 @@ jobs:
# Pulls all commits (needed for NX)
fetch-depth: 0

- name: "Derive appropriate SHAs for base and head for `nx affected` commands"
id: "setSHAs"
uses: "nrwl/nx-set-shas@76907e7e5d3cd17ddb5e2b123389f054bffcdd03" # v4

- name: "Setup resources and environment"
id: "setup"
uses: "anolilab/workflows/step/setup@main"
with:
node-version: "${{ matrix.node_version }}"
install-bun: false

- name: "Build"
run: "pnpm run build:packages"

- name: "Run test for browserslist-config-anolilab"
run: "pnpm run test:coverage:browserslist-config-anolilab"
# Temporary solution until Nx solve this https://github.com/nrwl/nx/issues/22259
- name: "Get changed files"
id: "files"
uses: "tj-actions/changed-files@c65cd883420fd2eb864698a825fc4162dd94482c" # v44.5.7
with:
files_ignore_from_source_file: ".github/ignore-files-for-nx-affected.yml"
base_sha: "${{ steps.setSHAs.outputs.base }}"
separator: ","

- name: "Run test for stylelint-config"
run: "pnpm run test:coverage:stylelint-config"
- name: "Build"
shell: "bash"
run: |
files="${{ steps.files.outputs.all_changed_files }}";
pnpm run build:affected:packages --files=${files//\\/\/}

- name: "Run stylelint config test"
run: "pnpm run test:stylelint"
- name: "Run tests"
shell: "bash"
run: |
files="${{ steps.files.outputs.all_changed_files }}";

- name: "Run babel config test"
run: "pnpm run test:babel"
if [[ ${{ matrix.os }} == "ubuntu-latest" && ${{ matrix.node_version }} == 22 ]]; then
pnpm run test:affected:coverage --files=${files//\\/\/}
else
pnpm run test:affected --files=${files//\\/\/}
fi

- name: "Prepare nx cache"
shell: "bash"
Expand Down
1 change: 0 additions & 1 deletion .husky/post-commit
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#!/bin/sh

. "$(dirname "$0")/_/husky.sh"
. "$(dirname "$0")/common.sh"

# The hook should exit with non-zero status after issuing
Expand Down
1 change: 0 additions & 1 deletion .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#!/bin/sh

. "$(dirname "$0")/_/husky.sh"
. "$(dirname "$0")/common.sh"

# The hook should exit with non-zero status after issuing
Expand Down
1 change: 0 additions & 1 deletion .husky/prepare-commit-msg
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#!/bin/sh

. "$(dirname "$0")/_/husky.sh"
. "$(dirname "$0")/common.sh"

echo --------------------------------------------
Expand Down
2 changes: 2 additions & 0 deletions packages/eslint-config/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
src/typegen.d.ts
src/utils/vitest-globals.ts
10 changes: 10 additions & 0 deletions packages/eslint-config/.prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
.gitkeep
.env*
*.ico
*.lock
dist
CHANGELOG.md
coverage
node_modules
.eslintcache
__fixtures__
6 changes: 6 additions & 0 deletions packages/eslint-config/.prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// eslint-disable-next-line import/no-extraneous-dependencies
import config from "@anolilab/prettier-config";

export default {
...config,
};
Loading
Loading