-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update Keychain for new modified-zip32 #1624
Conversation
f1b80a4
to
1ff8780
Compare
parentId, | ||
type, | ||
alias, | ||
info, | ||
source, | ||
timestamp | ||
); | ||
return derivedAccount; | ||
return derivedShieldedAccount; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note about this change: So we had a deriveAccount
method, which would alternatively call deriveTransparentAccount
or deriveShieldedAccount
, but it was never used for transparent, so I consolidated it into one function, deriveShieldedAccount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If/when we allow deriving only Transparent, we can add a specific call for it at that time
f18a4b8
to
f2b2f6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I builded the extension locally and can observe the new shielded address and the new viewing key, but transparent address was preserved
@mateuszjasiuk I think this is fine, things like sync won't work because this no longer returns shielded accounts (if they're outdated). But I also do think we need to communicate that this will happen if user has outdated accounts. Otherwise we'd need to make more changes to Namadillo |
Resolves #1611
m/44'/877'/0'/0'/2147483647'
modifiedZip32Path: "m/44'/877'/0'/0'/2147483647'"
Advanced
(will attach designs soon)Testing
New functionality:
main
(running extension locally so its store is preserved when switching branches)Manage Extensions
- When launching the account overview, you should see a warning to update your accountsThe most critical thing to confirm is:
namada
versionv1.1.1
+!)default_address
off of the viewing key (will introduce additional payment addresses after this release!)3.0.0
+)Notes
New shielded accounts generated from a mnemonic (not private key import) now look like this in storage:
This indicates:
So, with this we can check whether or not the user's shielded keys are supported.