Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAP-34936] Manage Django Settings with Dynaconf #15702

Open
wants to merge 10 commits into
base: devel
Choose a base branch
from

Conversation

rochacbruno
Copy link
Member

@rochacbruno rochacbruno commented Dec 11, 2024

AAP-34936

New or Enhanced Feature

Settings now managed by Dynaconf.

export DJANGO_SETTINGS_MODULE=awx.settings
dynaconf list
dynaconf inspect

NOTE: Currently depends on DAB ansible/django-ansible-base#689 to be merged.

@github-actions github-actions bot added component:api dependencies Pull requests that update a dependency file labels Dec 11, 2024
@AlanCoding
Copy link
Member

So how would the awx/conf (dynamic database backed settings) be handled with this?

@rochacbruno rochacbruno force-pushed the dynaconf branch 3 times, most recently from 2211f8f to 7cdfe26 Compare January 30, 2025 12:14
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 67.92453% with 34 lines in your changes missing coverage. Please review.

Project coverage is 75.25%. Comparing base (7d2b2d6) to head (4a6f6e8).
Report is 6 commits behind head on devel.

✅ All tests successful. No failed tests found.

@rochacbruno rochacbruno changed the title P.O.C: Manage Django Settings with Dynaconf [AAP-34936] Manage Django Settings with Dynaconf Feb 10, 2025
@rochacbruno rochacbruno marked this pull request as ready for review February 10, 2025 19:47
@rochacbruno
Copy link
Member Author

So how would the awx/conf (dynamic database backed settings) be handled with this?

@AlanCoding will not, this is going to be on phase 2 only.

@rooftopcellist
Copy link
Member

FYI, it looks like the awx-operator CI check failed. The AWX deployment by the operator itself was successful, but the job template failed. This may be related to the settings changes in this PR. I would next check that job templates run successfully in the AWX dev environment. If they do, then there are likely awx-operator changes needed around how we mount-in the settings.py file into the task and web pods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants