Adding a SSO login button to the /api/login endpoint #15777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added to /api/login, running version: AWX 24.6.1.dev Signed-off-by: Phil Duncan <philipduncan860@gmail.com>
Signed-off-by: Phil Duncan <philipduncan860@gmail.com>
github-actions
bot
added
component:api
dependencies
|
philip860
commented
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The https://localhost/api/login page traditional does not offer SAML SSO functionality when then SAML back-end is enabled in AWX, this pull request adds that feature to the /api/login page, along with Google SSO.
This PR is an attempt to resolve this still opened issue:
#12905
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
Before the change, if you enable SAML SSO, then logout of the awx-gui, and navigate to the /api/login page you should only see the standard login button.
After the change, if you enable SAML SSO and logout, and navigate to the /api/login endpoint you should be able to see a SAML hyperlink that will initiate a SSO login attempt through AWX to your specified SSO IdP.
I have also added the capability of adding Google as a login source to the /api/login endpoint.
The other traditional authentication sources such as Azure, Github, and OIDC are not yet options.