-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump template version to include multipart form data fix #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem reasonable. Are there some formatting changes in the API spec? Can't see the diff in GitHub because it's too large
@@ -373,21 +373,21 @@ yaml = ["ruamel.yaml"] | |||
|
|||
[[package]] | |||
name = "pytest" | |||
version = "8.0.0" | |||
version = "7.4.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for downgrading pytest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The template defines pytest as ^7.0.0, this needs to be bumped to ^8.0.0 to allow us to use a later version. I'll make this change, release a new template, and update this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the line endings have changed, probably because I downloaded it using Firefox (which reformatted it), and then I fixed the formatting in PyCharm. I'll try and fix this as well. |
This reverts commit 5b5104c.
…yansys/grantami-serverapi-openapi into feat/update-template-multipart
This PR has gotten really messy, I'm going to close it and create a new one. |
Bump swagger.json to MI 24.2.770, and update codegen template to support file upload and download.