Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump template version to include multipart form data fix #129

Closed
wants to merge 11 commits into from

Conversation

Andy-Grigg
Copy link
Collaborator

@Andy-Grigg Andy-Grigg commented Feb 6, 2024

Bump swagger.json to MI 24.2.770, and update codegen template to support file upload and download.

@Andy-Grigg Andy-Grigg marked this pull request as draft February 6, 2024 20:14
@Andy-Grigg Andy-Grigg marked this pull request as ready for review February 14, 2024 16:57
Copy link
Collaborator

@ludovicsteinbach ludovicsteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem reasonable. Are there some formatting changes in the API spec? Can't see the diff in GitHub because it's too large

@@ -373,21 +373,21 @@ yaml = ["ruamel.yaml"]

[[package]]
name = "pytest"
version = "8.0.0"
version = "7.4.4"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for downgrading pytest?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template defines pytest as ^7.0.0, this needs to be bumped to ^8.0.0 to allow us to use a later version. I'll make this change, release a new template, and update this PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andy-Grigg
Copy link
Collaborator Author

Changes seem reasonable. Are there some formatting changes in the API spec? Can't see the diff in GitHub because it's too large

It looks like the line endings have changed, probably because I downloaded it using Firefox (which reformatted it), and then I fixed the formatting in PyCharm. I'll try and fix this as well.

@Andy-Grigg
Copy link
Collaborator Author

This PR has gotten really messy, I'm going to close it and create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants