Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update template to support mypy compliance #132

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Update template to support mypy compliance #132

merged 2 commits into from
Feb 15, 2024

Conversation

Andy-Grigg
Copy link
Collaborator

@Andy-Grigg Andy-Grigg commented Feb 15, 2024 •
edited
Loading

Update template to new version and add mypy checking to CI

@Andy-Grigg Andy-Grigg changed the title Update pom and CI Update template to support mypy compliance Feb 15, 2024
ludovicsteinbach
ludovicsteinbach approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@ludovicsteinbach ludovicsteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had very brief scroll through; changes make sense given changes made to the template.

@Andy-Grigg Andy-Grigg merged commit be96d23 into main Feb 15, 2024
9 checks passed
@Andy-Grigg Andy-Grigg deleted the feat/support-mypy branch February 15, 2024 17:06
@ludovicsteinbach ludovicsteinbach mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludovicsteinbach ludovicsteinbach ludovicsteinbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andy-Grigg @ludovicsteinbach