Allow deserialization of undefined object #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Andy-Grigg
commented
Feb 16, 2024
| @@ -23,8 +24,9 @@ | |||
| from urllib.parse import quote | |||
|
|
|||
| import requests | |||
| from dateutil.parser import parse | |||
| from requests.structures import CaseInsensitiveDict | |||
| with warnings.catch_warnings(): | |||
There was a problem hiding this comment.
This was causing issues when I was trying to trap specific warnings.
Andy-Grigg
commented
Feb 16, 2024
| """ | ||
|
|
||
| if data is None: | ||
| return None | ||
|
|
||
| if klass_name == "object": | ||
| warnings.warn("Attempting to deserialize an object with no defined type. Returning " |
There was a problem hiding this comment.
I wanted to provide more information about the problematic model, but it's surprisingly hard to get to given the recursive calling.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
==========================================
+ Coverage 94.30% 94.35% +0.05%
==========================================
Files 7 7
Lines 773 780 +7
==========================================
+ Hits 729 736 +7
Misses 44 44 ☔ View full report in Codecov by Sentry. |
|
Codacy is complaining about something that black now enforces. I vote we stick with black. |
da1910
approved these changes
Feb 23, 2024
da1910
approved these changes
Feb 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #469
Handle the case where a model contains an undefined "object" and so cannot be deserialized. Add a warning for this case, and a test that checks the new behavior.