Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more PyAnsys actions #493

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Use more PyAnsys actions #493

merged 4 commits into from
Feb 20, 2024

Conversation

Andy-Grigg
Copy link
Contributor

@Andy-Grigg Andy-Grigg commented Feb 20, 2024

Closes #458

Uses Ansys actions to build, smoke test (i.e. build wheelhouses) and publish to PyPI and GitHub. This should resolve the GitHub release file attachment issue, although it's difficult to tell without actually releasing. Using 'dry-run' mode on the action looks good though.

The doc publishing is still manual, since we'll need to migrate openapi-common to versioned docs to do that. That's a much larger job.

@github-actions github-actions bot added the maintenance Package and maintenance related label Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (311a46a) 94.30% compared to head (7a56163) 94.30%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files           7        7           
  Lines         773      773           
=======================================
  Hits          729      729           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ludovicsteinbach ludovicsteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Definitely cleaner this way

We should probably remember to make an RC for the next release.

I think it used to be possible to use the doc-deploy actions even though the docs were not multi-versioned but maybe that changed. We should probably version the docs anyway so that'll get done at some point

@Andy-Grigg
Copy link
Contributor Author

I think it used to be possible to use the doc-deploy actions even though the docs were not multi-versioned but maybe that changed. We should probably version the docs anyway so that'll get done at some point

It may well be, but I think I'd like to do that as part of the migration to multi-versioned docs. I've created #494 for this

@Andy-Grigg Andy-Grigg added this pull request to the merge queue Feb 20, 2024
Merged via the queue into main with commit 1de1c39 Feb 20, 2024
30 checks passed
@Andy-Grigg Andy-Grigg deleted the maint/fix-release-action branch August 21, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release action fails to upload artifacts to the GitHub release
2 participants