-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Maxwell external circuit example #189
Conversation
@gmalinve please ignore this draft for now, it's only a placeholder, I will work on this later this week (and most likely change it completely) |
[like] Giulia Malinverno reacted to your message:
…________________________________
From: Irene Woyna ***@***.***>
Sent: Tuesday, August 6, 2024 12:10:55 PM
To: ansys-internal/pyaedt-examples ***@***.***>
Cc: Giulia Malinverno ***@***.***>; Mention ***@***.***>
Subject: Re: [ansys-internal/pyaedt-examples] FEAT: Maxwell external circuit example (PR #189)
[External Sender]
@gmalinve<https://github.com/gmalinve> please ignore this draft for now, it's only a placeholder, I will work on this later this week (and most likely change it completely)
—
Reply to this email directly, view it on GitHub<#189 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AYSI7MFXMPWJZRG5H7IARYTZQC4M7AVCNFSM6AAAAABMBXWCC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZRGEZTSMRZGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@IreneWoyna without the .sph file we can't test this :) |
circuit.export_netlist_from_schematic(netlist_file) creates the .sph file which is the imported into Maxwell design by maxwell.edit_external_circuit(netlist_file_path=netlist_file, schematic_design_name="test_circuit"). The .sph file can't exist before the circuit is created. |
@IreneWoyna oh my bad :) |
@gmalinve and @anur7 any ideas why this doesn't work? the plot is empty ## Create rectangular plotPlot winding currentsmaxwell.post.create_report( |
Hey @IreneWoyna, thanks for your changes. There are still many things to fix though. There are comments that have been resolved but that haven't been tackled. Like the imports, the constants, the winding objects etc. If you need help we can talk :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
# Conflicts: # examples/03-Maxwell2D/Maxwell_external_circuit.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Template
Description
Please provide a brief description of the changes in this pull request.
Checklist
Please complete the following checklist before submitting your pull request: