-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: adding missing Maxwell example (RMxprt) #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left minor comments that you can directly commit from Github @anur7
# Conflicts: # examples/03-Maxwell2D/Maxwell_RMxprt.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is missed the non graphical and num cores constant. Please check other examples and apply it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed NUM_CORES in the analyze part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Pull Request Template
Description
This example is present in pyaedt repo but not in this repository. See: https://github.com/ansys/pyaedt/blob/main/examples/03-Maxwell/RMxprt.py
Checklist
Please complete the following checklist before submitting your pull request: