Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: adding missing Maxwell example (RMxprt) #212

Merged
merged 14 commits into from
Aug 28, 2024

Conversation

anur7
Copy link
Collaborator

@anur7 anur7 commented Aug 19, 2024

Pull Request Template

Description

This example is present in pyaedt repo but not in this repository. See: https://github.com/ansys/pyaedt/blob/main/examples/03-Maxwell/RMxprt.py

Checklist

Please complete the following checklist before submitting your pull request:

  • I have followed the example template and guide lines to add/update an example.
  • I have tested the example locally and verified that it is working with the latest version of AEDT.
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.

@anur7 anur7 added the documentation Improvements or additions to documentation label Aug 19, 2024
@anur7 anur7 self-assigned this Aug 19, 2024
@anur7 anur7 linked an issue Aug 19, 2024 that may be closed by this pull request
@github-actions github-actions bot added enhancement New features or code improvements and removed documentation Improvements or additions to documentation labels Aug 19, 2024
@anur7 anur7 added documentation Improvements or additions to documentation and removed enhancement New features or code improvements labels Aug 19, 2024
@github-actions github-actions bot added enhancement New features or code improvements and removed documentation Improvements or additions to documentation labels Aug 19, 2024
@anur7 anur7 requested a review from IreneWoyna August 19, 2024 11:41
@anur7 anur7 removed the enhancement New features or code improvements label Aug 19, 2024
@github-actions github-actions bot added the enhancement New features or code improvements label Aug 19, 2024
Copy link
Collaborator

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left minor comments that you can directly commit from Github @anur7

@gmalinve gmalinve self-assigned this Aug 28, 2024
@gmalinve gmalinve marked this pull request as ready for review August 28, 2024 06:52
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is missed the non graphical and num cores constant. Please check other examples and apply it

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed NUM_CORES in the analyze part

@anur7 anur7 requested a review from Samuelopez-ansys August 28, 2024 07:43
@gmalinve gmalinve self-requested a review August 28, 2024 08:12
gmalinve
gmalinve previously approved these changes Aug 28, 2024
Copy link
Collaborator

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Samuelopez-ansys Samuelopez-ansys merged commit f8d4b7d into main Aug 28, 2024
11 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/Maxwell_RMxprt_example branch August 28, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example: create and export motor (Rmxprt)
3 participants