Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add template #215

Merged
merged 4 commits into from
Aug 27, 2024
Merged

add template #215

merged 4 commits into from
Aug 27, 2024

Conversation

gmalinve
Copy link
Collaborator

@gmalinve gmalinve commented Aug 23, 2024 •
edited by Devin-Crawford
Loading

Pull Request Template

Description

Please provide a brief description of the changes in this pull request.

Checklist

Please complete the following checklist before submitting your pull request:

  • I have followed the example template and guide lines to add/update an example.
  • I have tested the example locally and verified that it is working with the latest version of AEDT.
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.

@gmalinve gmalinve requested a review from anur7 August 23, 2024 06:49
@gmalinve gmalinve self-assigned this Aug 23, 2024
@gmalinve gmalinve linked an issue Aug 23, 2024 that may be closed by this pull request
EXAMPLE: Add a template for examples #154
Closed
@github-actions github-actions bot added the enhancement New features or code improvements label Aug 23, 2024
@Devin-Crawford
Minor updates
f500d16 
Minor update to README.md and template.py
@Devin-Crawford
Copy link
Collaborator

@gmalinve I made a few minor changes. Otherwise it looks good. Thanks!

@Samuelopez-ansys Samuelopez-ansys marked this pull request as ready for review August 26, 2024 05:58
SMoraisAnsys
SMoraisAnsys approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 08d5bbd into main Aug 27, 2024
11 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/template branch August 27, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

@anur7 anur7 Awaiting requested review from anur7

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78 maxcapodi78 is a code owner

@Devin-Crawford Devin-Crawford Awaiting requested review from Devin-Crawford

Assignees

@gmalinve gmalinve

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EXAMPLE: Add a template for examples
4 participants
@gmalinve @Devin-Crawford @Samuelopez-ansys @SMoraisAnsys